This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new a613ecd99fc Remove MetaDataVersionBasedPersistService (#34298)
a613ecd99fc is described below
commit a613ecd99fcdc6dc0bc517a564f520d6ac054f92
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jan 10 19:22:06 2025 +0800
Remove MetaDataVersionBasedPersistService (#34298)
---
.../MetaDataVersionBasedPersistService.java | 53 ----------------------
.../version/MetaDataVersionPersistService.java | 23 ++++++++--
2 files changed, 19 insertions(+), 57 deletions(-)
diff --git
a/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionBasedPersistService.java
b/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionBasedPersistService.java
deleted file mode 100644
index 29aa6b89246..00000000000
---
a/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionBasedPersistService.java
+++ /dev/null
@@ -1,53 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.metadata.persist.service.version;
-
-import org.apache.shardingsphere.infra.metadata.version.MetaDataVersion;
-
-import java.util.Collection;
-import java.util.List;
-
-/**
- * Meta data version based registry service.
- */
-public interface MetaDataVersionBasedPersistService {
-
- /**
- * Switch active version.
- *
- * @param metaDataVersions meta data versions
- */
- void switchActiveVersion(Collection<MetaDataVersion> metaDataVersions);
-
- /**
- * Get version path by active version.
- *
- * @param path path
- * @param activeVersion active version
- * @return version path
- */
- String getVersionPathByActiveVersion(String path, String activeVersion);
-
- /**
- * Get versions.
- *
- * @param path path
- * @return versions
- */
- List<String> getVersions(String path);
-}
diff --git
a/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionPersistService.java
b/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionPersistService.java
index 6e54bbdf32e..e28882cb2e7 100644
---
a/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionPersistService.java
+++
b/kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/persist/service/version/MetaDataVersionPersistService.java
@@ -31,11 +31,15 @@ import java.util.List;
*/
@RequiredArgsConstructor
@Slf4j
-public final class MetaDataVersionPersistService implements
MetaDataVersionBasedPersistService {
+public final class MetaDataVersionPersistService {
private final PersistRepository repository;
- @Override
+ /**
+ * Switch active version.
+ *
+ * @param metaDataVersions meta data versions
+ */
public void switchActiveVersion(final Collection<MetaDataVersion>
metaDataVersions) {
for (MetaDataVersion each : metaDataVersions) {
if
(each.getNextActiveVersion().equals(each.getCurrentActiveVersion())) {
@@ -48,12 +52,23 @@ public final class MetaDataVersionPersistService implements
MetaDataVersionBased
}
}
- @Override
+ /**
+ * Get version path by active version.
+ *
+ * @param path path
+ * @param activeVersion active version
+ * @return version path
+ */
public String getVersionPathByActiveVersion(final String path, final
String activeVersion) {
return repository.query(DatabaseMetaDataNodePath.getVersionPath(path,
activeVersion));
}
- @Override
+ /**
+ * Get versions.
+ *
+ * @param path path
+ * @return versions
+ */
public List<String> getVersions(final String path) {
List<String> result = repository.getChildrenKeys(path);
if (result.size() > 2) {
