linghengqian opened a new pull request, #34335:
URL: https://github.com/apache/shardingsphere/pull/34335
For #29052.
Changes proposed in this pull request:
- Support connecting to Firebird via jdbcUrl containing the absolute path
to fdb. The current PR was split from #34307 to facilitate review.
- This is due to #33773 which does not support resolving jdbcUrls like
`jdbc:firebird://localhost:32783//var/lib/firebird/data/demo_ds_2.fdb`.
- The current PR is affected by multiple external issues.
- Done discussion around LICENSE for
`org.firebirdsql.jdbc:jaybird:5.0.6.java8` not being distributed under the ASF
license at
https://github.com/apache/gravitino/issues/4352#issuecomment-2453295083 .
- Due to the change of the minimum supported JDK version to JDK17 as
reported by https://firebirdsql.org/en/news/jaybird-6-0-0-released , it is not
possible to use `org.firebirdsql.jdbc:jaybird:6.0.0` in unit tests of
shardingsphere. We still need JDK8 to run unit tests.
- According to some verification in
https://github.com/FirebirdSQL/jaybird/blob/v6.0.0/src/test/org/firebirdsql/jdbc/FBDriverTest.java
, it seems that the exception should not be thrown although a jdbcUrl like
`jdbc:firebirdsql:xxxxxxxx` does not make sense.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
