strongduanmu commented on code in PR #34332: URL: https://github.com/apache/shardingsphere/pull/34332#discussion_r1912892856
########## infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/select/pagination/PaginationContext.java: ########## @@ -58,7 +58,7 @@ private Long getValue(final PaginationValueSegment paginationValueSegment, final if (null == obj) { return null; } - return obj instanceof Long ? (long) obj : (int) obj; + return obj instanceof byte[] ? (long) (((byte[]) obj)[0] - '0') : obj instanceof Long ? (long) obj : (int) obj; Review Comment: Why is the LIMIT parameter a byte[]? Is this a special treatment of the MySQL protocol for the Go language? ########## infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/select/pagination/PaginationContext.java: ########## @@ -58,7 +58,7 @@ private Long getValue(final PaginationValueSegment paginationValueSegment, final if (null == obj) { return null; } - return obj instanceof Long ? (long) obj : (int) obj; + return obj instanceof byte[] ? (long) (((byte[]) obj)[0] - '0') : obj instanceof Long ? (long) obj : (int) obj; Review Comment: If possible, please add an E2E SQL that can reproduce this exception. You can add a new case in https://github.com/apache/shardingsphere/blob/master/test/e2e/sql/src/test/resources/cases/dql/e2e-dql-select.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org