kimmking commented on a change in pull request #5167: multiple threads loads 
unconfigured metadata
URL: 
https://github.com/apache/incubator-shardingsphere/pull/5167#discussion_r408084639
 
 

 ##########
 File path: 
shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
 ##########
 @@ -161,4 +167,32 @@ private TableMetaData decorate(final String tableName, 
final TableMetaData table
         }
         return result;
     }
+    
+    private Map<String, SchemaMetaData> asyncLoadSchemaMetaDataMap(final 
Map<String, DataSource> dataSourceMap, final int maxConnectionCount,
 
 Review comment:
   this method is the same with 
org.apache.shardingsphere.sql.parser.binder.metadata.schema.SchemaMetaDataLoader,
 could we merge and keep one method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to