Yash-cor commented on code in PR #34384:
URL: https://github.com/apache/shardingsphere/pull/34384#discussion_r1946274746
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java:
##########
@@ -54,16 +71,102 @@ public static CommonTableExpressionSegment bind(final
CommonTableExpressionSegme
}
if (recursive && segment.getAliasName().isPresent()) {
binderContext.getExternalTableBinderContexts().put(new
CaseInsensitiveString(segment.getAliasName().get()),
- new
SimpleTableSegmentBinderContext(segment.getColumns().stream().map(ColumnProjectionSegment::new).collect(Collectors.toList())));
+ createWithTableBinderContext(segment, binderContext));
}
SubqueryTableSegment subqueryTableSegment = new
SubqueryTableSegment(segment.getStartIndex(), segment.getStopIndex(),
segment.getSubquery());
subqueryTableSegment.setAlias(segment.getAliasSegment());
SubqueryTableSegment boundSubquerySegment =
SubqueryTableSegmentBinder.bind(subqueryTableSegment,
binderContext, LinkedHashMultimap.create(),
binderContext.getExternalTableBinderContexts());
CommonTableExpressionSegment result = new CommonTableExpressionSegment(
segment.getStartIndex(), segment.getStopIndex(),
boundSubquerySegment.getAliasSegment().orElse(null),
boundSubquerySegment.getSubquery());
- // TODO bind with columns
result.getColumns().addAll(segment.getColumns());
+ if (result.getAliasName().isPresent()) {
+ binderContext.getExternalTableBinderContexts().removeAll(new
CaseInsensitiveString(result.getAliasName().get()));
+ binderContext.getExternalTableBinderContexts().put(new
CaseInsensitiveString(result.getAliasName().get()),
+ createWithTableBinderContext(result, binderContext));
+ }
+ result.getColumns().clear();
Review Comment:
Thanks for reply @strongduanmu
This segment `result.getColumns().addAll(segment.getColumns());` and
`result.getColumns().clear();` are needed for creating
ExternalTableBinderContexts.
ExternalTableBinderContexts need the result with Column Segment and binded
SubqueryTableSegment.
And in order to perform column bind for CommonTableExpressionSegment we need
the updated ExternalTableBinderContexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
