(shardingsphere) branch master updated: Rename TableNodePathParser and ViewNodePathParser (#34687)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new b22e3e35b06 Rename TableNodePathParser and ViewNodePathParser (#34687)
b22e3e35b06 is described below

commit b22e3e35b068369af419985511e03f6fb4086bc5
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sun Feb 16 01:47:22 2025 +0800

    Rename TableNodePathParser and ViewNodePathParser (#34687)
    
    * Rename TableNodePathParser and ViewNodePathParser
    
    * Rename TableNodePathParser and ViewNodePathParser
---
 .../mode/node/path/metadata/database/TableNodePathParser.java    | 9 +++++----
 .../mode/node/path/metadata/database/ViewNodePathParser.java     | 9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git 
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableNodePathParser.java
 
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableNodePathParser.java
index 59aa6ccc9f9..f1033b050f1 100644
--- 
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableNodePathParser.java
+++ 
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableNodePathParser.java
@@ -32,6 +32,9 @@ import java.util.regex.Pattern;
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class TableNodePathParser {
     
+    private static final Pattern PATTERN = Pattern.compile(
+            TableNodePathGenerator.getTablePath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER) + "$", 
Pattern.CASE_INSENSITIVE);
+    
     private static final VersionNodePathParser VERSION_PARSER = new 
VersionNodePathParser(
             TableNodePathGenerator.getTablePath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER));
     
@@ -42,9 +45,7 @@ public final class TableNodePathParser {
      * @return found table name
      */
     public static Optional<String> findTableName(final String path) {
-        Pattern pattern = Pattern.compile(
-                
TableNodePathGenerator.getTablePath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER) + "$", 
Pattern.CASE_INSENSITIVE);
-        Matcher matcher = pattern.matcher(path);
+        Matcher matcher = PATTERN.matcher(path);
         return matcher.find() ? Optional.of(matcher.group(3)) : 
Optional.empty();
     }
     
@@ -52,7 +53,7 @@ public final class TableNodePathParser {
      * Is table path.
      *
      * @param path path
-     * @return true or false
+     * @return is table path or not
      */
     public static boolean isTablePath(final String path) {
         return findTableName(path).isPresent();
diff --git 
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewNodePathParser.java
 
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewNodePathParser.java
index 4186d5ba02d..76690382ec6 100644
--- 
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewNodePathParser.java
+++ 
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewNodePathParser.java
@@ -32,6 +32,9 @@ import java.util.regex.Pattern;
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class ViewNodePathParser {
     
+    private static final Pattern PATTERN = Pattern.compile(
+            ViewNodePathGenerator.getViewPath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER) + "$", 
Pattern.CASE_INSENSITIVE);
+    
     private static final VersionNodePathParser VERSION_PARSER = new 
VersionNodePathParser(
             ViewNodePathGenerator.getViewPath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER));
     
@@ -42,9 +45,7 @@ public final class ViewNodePathParser {
      * @return view name
      */
     public static Optional<String> findViewName(final String path) {
-        Pattern pattern = Pattern.compile(
-                ViewNodePathGenerator.getViewPath(NodePathPattern.IDENTIFIER, 
NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER) + "$", 
Pattern.CASE_INSENSITIVE);
-        Matcher matcher = pattern.matcher(path);
+        Matcher matcher = PATTERN.matcher(path);
         return matcher.find() ? Optional.of(matcher.group(3)) : 
Optional.empty();
     }
     
@@ -52,7 +53,7 @@ public final class ViewNodePathParser {
      * Is view path.
      *
      * @param path path
-     * @return true or false
+     * @return is view path or not
      */
     public static boolean isViewPath(final String path) {
         return findViewName(path).isPresent();