(shardingsphere) branch master updated: Remove comment in ColumnSegmentBinder and SubqueryTableBindUtils (#34837)

[zhaojinchao]

This is an automated email from the ASF dual-hosted git repository.

zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1e556e0ce00 Remove comment in ColumnSegmentBinder and 
SubqueryTableBindUtils (#34837)
1e556e0ce00 is described below

commit 1e556e0ce00b8c77aee03381842d57e1659bf682
Author: Zhengqiang Duan <duanzhengqi...@apache.org>
AuthorDate: Sun Mar 2 10:40:44 2025 +0800

    Remove comment in ColumnSegmentBinder and SubqueryTableBindUtils (#34837)
    
    Co-authored-by: shardingsphere <d...@shardingsphere.apache.org>
---
 .../binder/engine/segment/dml/expression/type/ColumnSegmentBinder.java   | 1 -
 .../infra/binder/engine/segment/util/SubqueryTableBindUtils.java         | 1 -
 2 files changed, 2 deletions(-)

diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/expression/type/ColumnSegmentBinder.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/expression/type/ColumnSegmentBinder.java
index 06c874804d1..97d3bb8b518 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/expression/type/ColumnSegmentBinder.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/expression/type/ColumnSegmentBinder.java
@@ -180,7 +180,6 @@ public final class ColumnSegmentBinder {
                         () -> new 
AmbiguousColumnException(segment.getExpression(), 
SEGMENT_TYPE_MESSAGES.getOrDefault(parentSegmentType, 
UNKNOWN_SEGMENT_TYPE_MESSAGE)));
             }
             inputColumnSegment = getColumnSegment(projectionSegment.get());
-            // NOTE: MIXED_TABLE 用于表示 JOIN 
之后的字段，其中可能会包含部分物理表字段，以及派生的临时表字段，同层级查询的 ORDER BY, GROUP BY, HAVING 会引用 JOIN 之后的字段
             tableSourceType = TableSourceType.MIXED_TABLE == 
each.getTableSourceType() ? 
getTableSourceTypeFromInputColumn(inputColumnSegment) : 
each.getTableSourceType();
             if (each instanceof SimpleTableSegmentBinderContext && 
((SimpleTableSegmentBinderContext) each).isFromWithSegment()) {
                 break;
diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/util/SubqueryTableBindUtils.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/util/SubqueryTableBindUtils.java
index df08dc2e268..be32b2c62b5 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/util/SubqueryTableBindUtils.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/util/SubqueryTableBindUtils.java
@@ -81,7 +81,6 @@ public final class SubqueryTableBindUtils {
         }
         ColumnSegmentBoundInfo inputColumnBoundInfo = 
originalColumn.getColumn().getColumnBoundInfo();
         TableSegmentBoundInfo tableBoundInfo = new 
TableSegmentBoundInfo(inputColumnBoundInfo.getOriginalDatabase(), 
inputColumnBoundInfo.getOriginalSchema());
-        // NOTE: MIXED_TABLE 用于表示 JOIN 之后的字段，其中可能会包含部分物理表字段，以及派生的临时表字段，同层级查询的 
ORDER BY, GROUP BY, HAVING 会引用 JOIN 之后的字段
         TableSourceType columnTableSourceType = TableSourceType.MIXED_TABLE == 
tableSourceType ? getTableSourceTypeFromInputColumn(inputColumnBoundInfo) : 
tableSourceType;
         newColumnSegment.setColumnBoundInfo(new 
ColumnSegmentBoundInfo(tableBoundInfo, inputColumnBoundInfo.getOriginalTable(), 
inputColumnBoundInfo.getOriginalColumn(), columnTableSourceType));
         ColumnProjectionSegment result = new 
ColumnProjectionSegment(newColumnSegment);