coveralls commented on issue #5213: Use factory strategy refactor rule configuration in orchestration m… URL: https://github.com/apache/incubator-shardingsphere/pull/5213#issuecomment-614620057 ## Pull Request Test Coverage Report for [Build 11097](https://coveralls.io/builds/30117364) * **46** of **52** **(88.46%)** changed or added relevant lines in **9** files are covered. * **97** unchanged lines in **10** files lost coverage. * Overall coverage increased (+**0.03%**) to **57.461%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/rule/converter/RuleConfigurationConvertFacade.java](https://coveralls.io/builds/30117364/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2Frule%2Fconverter%2FRuleConfigurationConvertFacade.java#L27) | 4 | 5 | 80.0% | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/rule/converter/RuleConfigurationConvertFactory.java](https://coveralls.io/builds/30117364/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2Frule%2Fconverter%2FRuleConfigurationConvertFactory.java#L33) | 9 | 10 | 90.0% | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/rule/converter/RuleConfigurationConverter.java](https://coveralls.io/builds/30117364/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2Frule%2Fconverter%2FRuleConfigurationConverter.java#L35) | 0 | 1 | 0.0% | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/rule/converter/ShardingRuleConfigurationConverter.java](https://coveralls.io/builds/30117364/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2Frule%2Fconverter%2FShardingRuleConfigurationConverter.java#L36) | 10 | 11 | 90.91% | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/30117364/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L165) | 8 | 9 | 88.89% | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/30117364/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L165) | 0 | 1 | 0.0% <!-- | **Total:** | **46** | **52** | **88.46%** | --> | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/splitter/InventoryDataTaskSplitter.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2Fsplitter%2FInventoryDataTaskSplitter.java#L135) | 1 | 98.39% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/DefaultSyncTaskFactory.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2FDefaultSyncTaskFactory.java#L32) | 4 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/exception/ScalingJobNotFoundException.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexception%2FScalingJobNotFoundException.java#L28) | 6 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/exception/SyncTaskExecuteException.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexception%2FSyncTaskExecuteException.java#L28) | 6 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/ScalingJobController.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2FScalingJobController.java#L58) | 8 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/inventory/InventoryDataSyncTask.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Finventory%2FInventoryDataSyncTask.java#L99) | 8 | 76.92% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/inventory/InventoryDataSyncTaskGroup.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Finventory%2FInventoryDataSyncTaskGroup.java#L64) | 9 | 52.63% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/incremental/IncrementalDataSyncTask.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fincremental%2FIncrementalDataSyncTask.java#L44) | 15 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskController.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskController.java#L32) | 20 | 0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/ShardingScalingJobPreparer.java](https://coveralls.io/builds/30117364/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2FShardingScalingJobPreparer.java#L40) | 20 | 0% | <!-- | **Total:** | **97** | | --> | Totals | [](https://coveralls.io/builds/30117364) | | :-- | --: | | Change from base [Build 11087](https://coveralls.io/builds/30112487): | 0.03% | | Covered Lines: | 11841 | | Relevant Lines: | 20607 | --- ##### 💛 - [Coveralls](https://coveralls.io)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
