This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new a2de00a9ad1 Remove useless equals methods on ParameterMarkerSegment's 
impl (#35666)
a2de00a9ad1 is described below

commit a2de00a9ad16996e8e3aa384def3f4c30ef8dfad
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Jun 11 00:00:29 2025 +0800

    Remove useless equals methods on ParameterMarkerSegment's impl (#35666)
---
 .../segment/dml/expr/simple/ParameterMarkerExpressionSegment.java    | 2 --
 .../dml/pagination/limit/ParameterMarkerLimitValueSegment.java       | 2 --
 .../dml/pagination/rownum/ParameterMarkerRowNumberValueSegment.java  | 2 --
 .../sql/parser/statement/core/statement/AbstractSQLStatement.java    | 5 ++---
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/expr/simple/ParameterMarkerExpressionSegment.java
 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/expr/simple/ParameterMarkerExpressionSegment.java
index 7a90bdab782..5c40807f912 100644
--- 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/expr/simple/ParameterMarkerExpressionSegment.java
+++ 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/expr/simple/ParameterMarkerExpressionSegment.java
@@ -17,7 +17,6 @@
 
 package 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.simple;
 
-import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import lombok.Setter;
@@ -36,7 +35,6 @@ import java.util.Optional;
  */
 @RequiredArgsConstructor
 @Getter
-@EqualsAndHashCode(exclude = "boundInfo")
 public class ParameterMarkerExpressionSegment implements 
SimpleExpressionSegment, ProjectionSegment, AliasAvailable, 
ParameterMarkerSegment {
     
     private final int startIndex;
diff --git 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/limit/ParameterMarkerLimitValueSegment.java
 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/limit/ParameterMarkerLimitValueSegment.java
index 84beb18e066..48791159d65 100644
--- 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/limit/ParameterMarkerLimitValueSegment.java
+++ 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/limit/ParameterMarkerLimitValueSegment.java
@@ -17,7 +17,6 @@
 
 package 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.pagination.limit;
 
-import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.pagination.ParameterMarkerPaginationValueSegment;
 
@@ -25,7 +24,6 @@ import 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.paginatio
  * Limit value segment for parameter marker.
  */
 @Getter
-@EqualsAndHashCode(callSuper = true)
 public final class ParameterMarkerLimitValueSegment extends LimitValueSegment 
implements ParameterMarkerPaginationValueSegment {
     
     private final int parameterIndex;
diff --git 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/rownum/ParameterMarkerRowNumberValueSegment.java
 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/rownum/ParameterMarkerRowNumberValueSegment.java
index 33df995354f..cdc7891d0a2 100644
--- 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/rownum/ParameterMarkerRowNumberValueSegment.java
+++ 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/pagination/rownum/ParameterMarkerRowNumberValueSegment.java
@@ -17,7 +17,6 @@
 
 package 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.pagination.rownum;
 
-import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.pagination.ParameterMarkerPaginationValueSegment;
 
@@ -25,7 +24,6 @@ import 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.paginatio
  * Row number value segment for parameter marker.
  */
 @Getter
-@EqualsAndHashCode(callSuper = true)
 public final class ParameterMarkerRowNumberValueSegment extends 
RowNumberValueSegment implements ParameterMarkerPaginationValueSegment {
     
     private final int parameterIndex;
diff --git 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/AbstractSQLStatement.java
 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/AbstractSQLStatement.java
index a3d17616a21..48adfc5b76f 100644
--- 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/AbstractSQLStatement.java
+++ 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/AbstractSQLStatement.java
@@ -23,7 +23,6 @@ import 
org.apache.shardingsphere.sql.parser.statement.core.segment.generic.Comme
 import 
org.apache.shardingsphere.sql.parser.statement.core.segment.generic.ParameterMarkerSegment;
 
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.LinkedList;
 
@@ -33,9 +32,9 @@ import java.util.LinkedList;
 @Getter
 public class AbstractSQLStatement implements SQLStatement {
     
-    private final Collection<Integer> uniqueParameterIndexes = new HashSet<>();
+    private final Collection<Integer> uniqueParameterIndexes = new 
LinkedHashSet<>();
     
-    private final Collection<ParameterMarkerSegment> parameterMarkerSegments = 
new LinkedHashSet<>();
+    private final Collection<ParameterMarkerSegment> parameterMarkerSegments = 
new LinkedList<>();
     
     private final Collection<String> variableNames = new 
CaseInsensitiveSet<>();
     

Reply via email to