This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 52ebcf2d6e1 Use SQLStatement.addParameterMarkerSegments() instead of 
getParameterMarkerSegments() (#35664)
52ebcf2d6e1 is described below

commit 52ebcf2d6e110355867d9a48422704a9ae89b1cb
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Jun 10 21:53:30 2025 +0800

    Use SQLStatement.addParameterMarkerSegments() instead of 
getParameterMarkerSegments() (#35664)
---
 .../sql/parser/doris/visitor/statement/DorisStatementVisitor.java   | 2 +-
 .../sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java   | 2 +-
 .../oracle/visitor/statement/type/OracleDMLStatementVisitor.java    | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
 
b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
index 36e68b9a8ca..fe190e43519 100644
--- 
a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
+++ 
b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
@@ -1464,7 +1464,7 @@ public abstract class DorisStatementVisitor extends 
DorisStatementBaseVisitor<AS
     
     private SubquerySegment createInsertSelectSegment(final 
InsertSelectClauseContext ctx) {
         SelectStatement selectStatement = (SelectStatement) 
visit(ctx.select());
-        
selectStatement.getParameterMarkerSegments().addAll(getParameterMarkerSegments());
+        
selectStatement.addParameterMarkerSegments(getParameterMarkerSegments());
         return new SubquerySegment(ctx.select().start.getStartIndex(), 
ctx.select().stop.getStopIndex(), selectStatement, 
getOriginalText(ctx.select()));
     }
     
diff --git 
a/parser/sql/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java
 
b/parser/sql/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java
index 7a484bca8a4..08d98758506 100644
--- 
a/parser/sql/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java
+++ 
b/parser/sql/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java
@@ -1481,7 +1481,7 @@ public abstract class MySQLStatementVisitor extends 
MySQLStatementBaseVisitor<AS
     
     private SubquerySegment createInsertSelectSegment(final 
InsertSelectClauseContext ctx) {
         SelectStatement selectStatement = (SelectStatement) 
visit(ctx.select());
-        
selectStatement.getParameterMarkerSegments().addAll(getParameterMarkerSegments());
+        
selectStatement.addParameterMarkerSegments(getParameterMarkerSegments());
         return new SubquerySegment(ctx.select().start.getStartIndex(), 
ctx.select().stop.getStopIndex(), selectStatement, 
getOriginalText(ctx.select()));
     }
     
diff --git 
a/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
 
b/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
index 62911eed199..bca9d68771c 100644
--- 
a/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
+++ 
b/parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
@@ -1331,7 +1331,7 @@ public final class OracleDMLStatementVisitor extends 
OracleStatementVisitor impl
         if (null != ctx.whereClause()) {
             result.setWhere((WhereSegment) visit(ctx.whereClause()));
         }
-        
result.getParameterMarkerSegments().addAll(popAllStatementParameterMarkerSegments());
+        
result.addParameterMarkerSegments(popAllStatementParameterMarkerSegments());
         return result;
     }
     
@@ -1400,7 +1400,7 @@ public final class OracleDMLStatementVisitor extends 
OracleStatementVisitor impl
         }
         SelectStatement subquery = (SelectStatement) visit(ctx.subquery());
         SubquerySegment subquerySegment = new 
SubquerySegment(ctx.subquery().start.getStartIndex(), 
ctx.subquery().stop.getStopIndex(), subquery, getOriginalText(ctx.subquery()));
-        
subquerySegment.getSelect().getParameterMarkerSegments().addAll(popAllStatementParameterMarkerSegments());
+        
subquerySegment.getSelect().addParameterMarkerSegments(popAllStatementParameterMarkerSegments());
         SubqueryTableSegment result = new 
SubqueryTableSegment(ctx.subquery().start.getStartIndex(), 
ctx.subquery().stop.getStopIndex(), subquerySegment);
         if (null != ctx.alias()) {
             result.setAlias((AliasSegment) visit(ctx.alias()));
@@ -1418,7 +1418,7 @@ public final class OracleDMLStatementVisitor extends 
OracleStatementVisitor impl
         if (null != ctx.deleteWhereClause()) {
             result.setDeleteWhere((WhereSegment) 
visit(ctx.deleteWhereClause()));
         }
-        
result.getParameterMarkerSegments().addAll(popAllStatementParameterMarkerSegments());
+        
result.addParameterMarkerSegments(popAllStatementParameterMarkerSegments());
         return result;
     }
     

Reply via email to