terrymanu commented on a change in pull request #5388:
URL: https://github.com/apache/shardingsphere/pull/5388#discussion_r417741512
##########
File path:
sharding-jdbc/sharding-jdbc-core/src/test/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatementTest.java
##########
@@ -33,6 +34,10 @@
import static org.junit.Assert.assertTrue;
public final class ShardingPreparedStatementTest extends
AbstractShardingJDBCDatabaseAndTableTest {
+
+ private static final String
INSERT_MULTI_VALUES_WITH_GENERATE_SHARDING_KEY_SQL = "INSERT INTO t_user (name)
VALUES (?),(?),(?),(?)";
+
+ private static final String
SELECT_FOR_INSERT_MULTI_VALUES_WITH_GENERATE_SHARDING_KEY_SQL = "select name
from t_user where id=%d";
Review comment:
It is better if use upper case for keyword in SQL
##########
File path:
sharding-jdbc/sharding-jdbc-core/src/test/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatementTest.java
##########
@@ -77,13 +82,130 @@ public void assertAddBatch() throws SQLException {
}
}
}
+
+ // FIXME Batch Insert @Test
Review comment:
It is better to use @Ignore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
