This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 3ff8c413604 Refactor CreateDatabaseProxyBackendHandlerTest (#36826)
3ff8c413604 is described below
commit 3ff8c413604dfc107f8726283e1e5852ff7c7c46
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Oct 8 23:59:00 2025 +0800
Refactor CreateDatabaseProxyBackendHandlerTest (#36826)
---
.../type/CreateDatabaseProxyBackendHandlerTest.java | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/database/type/CreateDatabaseProxyBackendHandlerTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/database/type/CreateDatabaseProxyBackendHandlerTest.java
index 2394cb369c9..cfc0b0d769a 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/database/type/CreateDatabaseProxyBackendHandlerTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/database/type/CreateDatabaseProxyBackendHandlerTest.java
@@ -23,7 +23,6 @@ import
org.apache.shardingsphere.proxy.backend.response.header.update.UpdateResp
import
org.apache.shardingsphere.sql.parser.statement.core.statement.type.ddl.database.CreateDatabaseStatement;
import org.apache.shardingsphere.test.infra.framework.mock.AutoMockExtension;
import org.apache.shardingsphere.test.infra.framework.mock.StaticMockSettings;
-import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
@@ -42,30 +41,23 @@ class CreateDatabaseProxyBackendHandlerTest {
@Mock
private CreateDatabaseStatement statement;
- private CreateDatabaseProxyBackendHandler handler;
-
- @BeforeEach
- void setUp() {
- handler = new CreateDatabaseProxyBackendHandler(statement);
- }
-
@Test
void assertExecuteCreateNewDatabase() throws SQLException {
when(statement.getDatabaseName()).thenReturn("bar_db");
- assertThat(handler.execute(), isA(UpdateResponseHeader.class));
+ assertThat(new CreateDatabaseProxyBackendHandler(statement).execute(),
isA(UpdateResponseHeader.class));
}
@Test
void assertExecuteCreateExistDatabase() {
when(statement.getDatabaseName()).thenReturn("foo_db");
when(ProxyContext.getInstance().databaseExists("foo_db")).thenReturn(true);
- assertThrows(DatabaseCreateExistsException.class, () ->
handler.execute());
+ assertThrows(DatabaseCreateExistsException.class, () -> new
CreateDatabaseProxyBackendHandler(statement).execute());
}
@Test
void assertExecuteCreateExistDatabaseWithIfNotExists() throws SQLException
{
when(statement.getDatabaseName()).thenReturn("foo_db");
when(statement.isIfNotExists()).thenReturn(true);
- assertThat(handler.execute(), isA(UpdateResponseHeader.class));
+ assertThat(new CreateDatabaseProxyBackendHandler(statement).execute(),
isA(UpdateResponseHeader.class));
}
}