terrymanu commented on issue #36979:
URL:
https://github.com/apache/shardingsphere/issues/36979#issuecomment-3486434174
# Fix Suggestion
Based on my in-depth analysis of GitHub issue #36994, I have identified
the root cause and solution for this problem.
## Root Cause
The ResultSetUtils.convertDateValue method in ShardingSphere lacks support
for the java.time.LocalDate type. When executing SELECT MIN(trade_date)
queries, MySQL returns a java.sql.Date type, but MyBatis fails to convert
it to LocalDate.
## Solution
You need to add LocalDate support to the convertDateValue method in the
ResultSetUtils.java file:
```java
private static Object convertDateValue(final Date value, final Class<?>
convertType) {
switch (convertType.getName()) {
case "java.sql.Date":
return new java.sql.Date(value.getTime());
case "java.sql.Time":
return new Time(value.getTime());
case "java.sql.Timestamp":
return new Timestamp(value.getTime());
case "java.time.LocalDate":
return value.toLocalDate();
case "java.lang.String":
return value.toString();
default:
throw new UnsupportedDataTypeConversionException(convertType,
value);
}
}
```
## Modification Location
- File:
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/execute/result/query/impl/driver/jdbc/type/util/ResultSetUtils.java
- Method: convertDateValue
- Lines: Approximately 191-204
## Enthusiastic Invitation to Submit PR
We warmly welcome you to contribute this fix to the Apache ShardingSphere
community! This is an excellent entry-level contribution that can help solve a
real user problem.
## Steps to Submit PR:
1. Fork Repository: Fork the ShardingSphere repository on GitHub
2. Create Branch: Create a new feature branch, for example
fix/localdate-conversion-issue
3. Modify Code: Modify the ResultSetUtils.java file according to the above
suggestion
4. Add Tests: Add unit tests for LocalDate conversion in
ResultSetUtilsTest.java
5. Run Tests: Ensure all tests pass
6. Submit PR: Submit a Pull Request to the dev branch of ShardingSphere
## Test Suggestions:
Add the following test case in ResultSetUtilsTest.java:
```java
@Test
public void assertConvertDateValueToLocalDate() {
Date date = new Date(System.currentTimeMillis());
LocalDate localDate = (LocalDate) ResultSetUtils.convertValue(date,
LocalDate.class);
assertThat(localDate, is(date.toLocalDate()));
}
```
## Contribution Value:
This fix will help all developers using the modern Java Time API (Java 8+)
to better integrate ShardingSphere with ORM frameworks like MyBatis. Your
contribution will be recorded in the project's contributor list, which
is valuable experience in participating in Apache top-level projects.
Our community is very willing to help new contributors. If you encounter
any issues during development, you can ask questions in the GitHub issue or
seek help in the community communication group.
Looking forward to your PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
