linghengqian commented on code in PR #36942:
URL: https://github.com/apache/shardingsphere/pull/36942#discussion_r2518638570
##########
.github/workflows/nightly-e2e-sql.yml:
##########
@@ -53,8 +53,11 @@ jobs:
restore-keys: |
${{ needs.global-environment.outputs.GLOBAL_CACHE_PREFIX
}}-maven-third-party-e2e-cache-
${{ needs.global-environment.outputs.GLOBAL_CACHE_PREFIX
}}-maven-third-party-
+ - uses: gauthamchandra/[email protected]
+ with:
+ version: '1.0.3'
- name: Build E2E Image
- run: ./mvnw -B clean install -am -pl test/e2e/sql -Pe2e.env.docker
-DskipTests -Dspotless.apply.skip=true
+ run: mvnd -B clean install -am -pl test/e2e/sql -Pe2e.env.docker
-DskipTests -Dspotless.apply.skip=true
Review Comment:
I don't understand why we need to use `mvnd` this way, which essentially
throws away the existing `mvnw` script. Can't we just execute the following
command directly in `PowerShell 7`/`Bash` to have `mvnw` update its
configuration file to download the `mvnd` binary,
```shell
mvn wrapper:wrapper "-Dtype=only-script" "-Dmvnd=1.0.3"
```
This is already documented at
https://github.com/apache/maven-wrapper/blob/master/maven-wrapper-plugin/src/it/projects/test_mvnd/test.properties
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
