This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 16a8e148cdb Remove redundant database type assertions in SQL
Federation function register tests (#37321)
16a8e148cdb is described below
commit 16a8e148cdbae9c5373191edf74331e58d9c0e6f
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Dec 10 01:06:32 2025 +0800
Remove redundant database type assertions in SQL Federation function
register tests (#37321)
---
.../opengauss/OpenGaussSQLFederationFunctionRegisterTest.java | 1 -
.../oracle/OracleSQLFederationConnectionConfigBuilderTest.java | 1 -
.../postgresql/PostgreSQLSQLFederationFunctionRegisterTest.java | 1 -
3 files changed, 3 deletions(-)
diff --git
a/kernel/sql-federation/dialect/opengauss/src/test/java/org/apache/shardingsphere/sqlfederation/opengauss/OpenGaussSQLFederationFunctionRegisterTest.java
b/kernel/sql-federation/dialect/opengauss/src/test/java/org/apache/shardingsphere/sqlfederation/opengauss/OpenGaussSQLFederationFunctionRegisterTest.java
index 7620cd02794..ca94c3180a8 100644
---
a/kernel/sql-federation/dialect/opengauss/src/test/java/org/apache/shardingsphere/sqlfederation/opengauss/OpenGaussSQLFederationFunctionRegisterTest.java
+++
b/kernel/sql-federation/dialect/opengauss/src/test/java/org/apache/shardingsphere/sqlfederation/opengauss/OpenGaussSQLFederationFunctionRegisterTest.java
@@ -45,7 +45,6 @@ class OpenGaussSQLFederationFunctionRegisterTest {
void assertRegisterPgCatalogFunctionsAndDelegate() {
SchemaPlus schemaPlus = Frameworks.createRootSchema(true);
register.registerFunction(schemaPlus, "pg_catalog");
- assertThat(register.getDatabaseType(), is("openGauss"));
assertFunction(schemaPlus.getFunctions("gs_password_deadline"),
OpenGaussSystemFunction.class, "gsPasswordDeadline");
assertFunction(schemaPlus.getFunctions("intervaltonum"),
OpenGaussSystemFunction.class, "intervalToNum");
assertFunction(schemaPlus.getFunctions("gs_password_notifyTime"),
OpenGaussSystemFunction.class, "gsPasswordNotifyTime");
diff --git
a/kernel/sql-federation/dialect/oracle/src/test/java/org/apache/shardingsphere/sqlfederation/oracle/OracleSQLFederationConnectionConfigBuilderTest.java
b/kernel/sql-federation/dialect/oracle/src/test/java/org/apache/shardingsphere/sqlfederation/oracle/OracleSQLFederationConnectionConfigBuilderTest.java
index cda8d85cdce..2b666599935 100644
---
a/kernel/sql-federation/dialect/oracle/src/test/java/org/apache/shardingsphere/sqlfederation/oracle/OracleSQLFederationConnectionConfigBuilderTest.java
+++
b/kernel/sql-federation/dialect/oracle/src/test/java/org/apache/shardingsphere/sqlfederation/oracle/OracleSQLFederationConnectionConfigBuilderTest.java
@@ -44,6 +44,5 @@ class OracleSQLFederationConnectionConfigBuilderTest {
assertThat(actualConfig.conformance(),
is(SqlConformanceEnum.ORACLE_12));
assertNotNull(actualConfig.fun(SqlOperatorTable.class, null));
assertThat(actualConfig.caseSensitive(), is(Lex.ORACLE.caseSensitive));
- assertThat(builder.getDatabaseType(), is("Oracle"));
}
}
diff --git
a/kernel/sql-federation/dialect/postgresql/src/test/java/org/apache/shardingsphere/sqlfederation/postgresql/PostgreSQLSQLFederationFunctionRegisterTest.java
b/kernel/sql-federation/dialect/postgresql/src/test/java/org/apache/shardingsphere/sqlfederation/postgresql/PostgreSQLSQLFederationFunctionRegisterTest.java
index b1f47150d3f..808ddfc806e 100644
---
a/kernel/sql-federation/dialect/postgresql/src/test/java/org/apache/shardingsphere/sqlfederation/postgresql/PostgreSQLSQLFederationFunctionRegisterTest.java
+++
b/kernel/sql-federation/dialect/postgresql/src/test/java/org/apache/shardingsphere/sqlfederation/postgresql/PostgreSQLSQLFederationFunctionRegisterTest.java
@@ -44,7 +44,6 @@ class PostgreSQLSQLFederationFunctionRegisterTest {
void assertRegisterPgCatalogFunctions() {
SchemaPlus schemaPlus = Frameworks.createRootSchema(true);
register.registerFunction(schemaPlus, "pg_catalog");
- assertThat(register.getDatabaseType(), is("PostgreSQL"));
assertFunction(schemaPlus.getFunctions("pg_table_is_visible"),
"pgTableIsVisible");
assertFunction(schemaPlus.getFunctions("pg_get_userbyid"),
"pgGetUserById");
}