This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 18f01ec9d30 Rename SqlTypeNameConverter (#37340)
18f01ec9d30 is described below
commit 18f01ec9d3097842a957851eb9e989b494a17a96
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Dec 11 10:39:05 2025 +0800
Rename SqlTypeNameConverter (#37340)
---
.../expression/impl/TypeCastExpressionConverter.java | 4 ++--
...{DataTypeConverter.java => SqlTypeNameConverter.java} | 4 ++--
...eConverterTest.java => SqlTypeNameConverterTest.java} | 16 ++++++++--------
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/TypeCastExpressionConverter.java
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/TypeCastExpressionConverter.java
index fa1e443c9d2..c88565b0b93 100644
---
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/TypeCastExpressionConverter.java
+++
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/TypeCastExpressionConverter.java
@@ -28,7 +28,7 @@ import org.apache.calcite.sql.fun.SqlCastFunction;
import org.apache.calcite.sql.parser.SqlParserPos;
import
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.TypeCastExpression;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.ExpressionConverter;
-import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.type.DataTypeConverter;
+import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.type.SqlTypeNameConverter;
import java.util.Arrays;
import java.util.Optional;
@@ -50,7 +50,7 @@ public final class TypeCastExpressionConverter {
if (!expression.isPresent()) {
return Optional.empty();
}
- SqlTypeNameSpec sqlTypeName = new
SqlBasicTypeNameSpec(DataTypeConverter.convert(segment.getDataType().toUpperCase()),
SqlParserPos.ZERO);
+ SqlTypeNameSpec sqlTypeName = new
SqlBasicTypeNameSpec(SqlTypeNameConverter.convert(segment.getDataType().toUpperCase()),
SqlParserPos.ZERO);
return Optional.of(new SqlBasicCall(new SqlCastFunction(),
Arrays.asList(expression.get(), new SqlDataTypeSpec(sqlTypeName,
SqlParserPos.ZERO)), SqlParserPos.ZERO));
}
}
diff --git
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverter.java
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverter.java
similarity index 96%
rename from
kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverter.java
rename to
kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverter.java
index 5c3a9c4c02a..e930af258d1 100644
---
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverter.java
+++
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverter.java
@@ -25,10 +25,10 @@ import org.apache.calcite.sql.type.SqlTypeName;
import java.util.Map;
/**
- * Data type converter.
+ * SQL type name converter.
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
-public final class DataTypeConverter {
+public final class SqlTypeNameConverter {
private static final Map<String, SqlTypeName> REGISTRY = new
CaseInsensitiveMap<>();
diff --git
a/kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverterTest.java
b/kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverterTest.java
similarity index 65%
rename from
kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverterTest.java
rename to
kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverterTest.java
index 157b667bbb6..90fa58415e4 100644
---
a/kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/DataTypeConverterTest.java
+++
b/kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/type/SqlTypeNameConverterTest.java
@@ -23,20 +23,20 @@ import org.junit.jupiter.api.Test;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-class DataTypeConverterTest {
+class SqlTypeNameConverterTest {
@Test
void assertConvertRegisteredDataType() {
- assertThat(DataTypeConverter.convert("int"), is(SqlTypeName.INTEGER));
- assertThat(DataTypeConverter.convert("int2"),
is(SqlTypeName.SMALLINT));
- assertThat(DataTypeConverter.convert("int4"), is(SqlTypeName.INTEGER));
- assertThat(DataTypeConverter.convert("int8"), is(SqlTypeName.BIGINT));
- assertThat(DataTypeConverter.convert("money"),
is(SqlTypeName.DECIMAL));
+ assertThat(SqlTypeNameConverter.convert("int"),
is(SqlTypeName.INTEGER));
+ assertThat(SqlTypeNameConverter.convert("int2"),
is(SqlTypeName.SMALLINT));
+ assertThat(SqlTypeNameConverter.convert("INT4"),
is(SqlTypeName.INTEGER));
+ assertThat(SqlTypeNameConverter.convert("INT8"),
is(SqlTypeName.BIGINT));
+ assertThat(SqlTypeNameConverter.convert("money"),
is(SqlTypeName.DECIMAL));
}
@Test
void assertConvertUnregisteredDataType() {
- assertThat(DataTypeConverter.convert("varchar"),
is(SqlTypeName.VARCHAR));
- assertThat(DataTypeConverter.convert("VARCHAR"),
is(SqlTypeName.VARCHAR));
+ assertThat(SqlTypeNameConverter.convert("varchar"),
is(SqlTypeName.VARCHAR));
+ assertThat(SqlTypeNameConverter.convert("VARCHAR"),
is(SqlTypeName.VARCHAR));
}
}
