ccxxxyy commented on PR #37509: URL: https://github.com/apache/shardingsphere/pull/37509#issuecomment-3692013166
@terrymanu Hi! I hope my revisions can meet the requirements. Hope you could take a look when you have a moment. - Regarding ALIAS and PARAMETER: Doris does not treat them as reserved, although they are still kept in the DorisKeyword file. However, in the previous commit, I have added ALIAS and PARAMETER to the identifierKeywordsUnambiguous rule in the BaseRule file. I hope this can resolve any potential conflicts. - Regarding the SELECT INTO OUTFILE statement: I haven't found any description of COLUMNS/LINES/CHARACTER in all the official [documentation ](https://doris.apache.org/zh-CN/docs/4.x/data-operate/export/outfile) related to this statement. The content I can only find about it is <query_stmt> INTO OUTFILE "<file_path>" [ FORMAT AS <format_as> ] [ <properties> ], and this is also what I want to support and fix in the PR. Therefore, I didn't consider COLUMNS/LINES/CHARACTER before. - Regarding `array_filter`: For every unsupported syntax mentioned in the issue, I will do my best to fix it. Before proposing a PR, I attempted to support the parsing of the `array_filter` syntax, but my several attempts all ended in failure. The difficulty currently exceeds my ability to solve it. Therefore, I will try to clearly express in the PR title which syntaxes from the issue I have fixed. Meanwhile, I use "for" instead of "fix" when referring to the issue in the PR. I hope that when reviewing the issue in the future, I can successfully propose parsing solutions for these syntaxes that are currently difficult for me, or that more excellent contributors can complete the support. If there are any places where I need to provide further explanations or descriptions about the fixes, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
