snac21 commented on code in PR #2491:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2491#discussion_r2653027976
##########
pom.xml:
##########
@@ -552,6 +560,33 @@
</plugins>
</pluginManagement>
<plugins>
+ <!-- Maven CI-Friendly Version Management -->
+ <plugin>
Review Comment:
Thank you for the label. I'd like to provide more context regarding this PR:
Consistency in Version Management: I noticed that the examples module
([link](https://github.com/apache/shardingsphere-elasticjob/blob/master/examples/pom.xml))
already uses ${revision} for version management. However, the main ElasticJob
modules have not yet adopted this approach. This PR aims to unify the
versioning strategy across the entire project for easier maintenance.
Fixing Build Issues: I found that elasticjob-ui currently references version
3.1.0. However, this version appears to be missing from the Maven Central
Repository (possibly due to a missing release or build step in the past). By
introducing ${revision} management, it will be much easier to handle
project-wide packaging and ensure that all modules (including UI) are built and
synchronized correctly during the CI/CD process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
