This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new ab772133d4f Upgrade checkstyle version (#37663)
ab772133d4f is described below
commit ab772133d4fc1aed3b993602cca5fef624fffe16
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Jan 6 22:58:01 2026 +0800
Upgrade checkstyle version (#37663)
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
* Upgrade checkstyle version
---
.../database/connector/core/resultset/DialectResultSetMapper.java | 2 +-
docs/community/content/involved/contribute/dev-env.cn.md | 2 +-
docs/community/content/involved/contribute/dev-env.en.md | 2 +-
.../infra/algorithm/loadbalancer/spi/LoadBalanceAlgorithm.java | 2 +-
.../update/rdl/rule/spi/global/GlobalRuleDefinitionExecutor.java | 2 +-
.../infra/util/directory/ClasspathResourceDirectoryReader.java | 8 ++------
pom.xml | 2 +-
src/resources/checkstyle.xml | 4 ----
8 files changed, 8 insertions(+), 16 deletions(-)
diff --git
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/resultset/DialectResultSetMapper.java
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/resultset/DialectResultSetMapper.java
index 166a4481576..41740141656 100644
---
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/resultset/DialectResultSetMapper.java
+++
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/resultset/DialectResultSetMapper.java
@@ -58,7 +58,7 @@ public interface DialectResultSetMapper extends
DatabaseTypedSPI {
* @return value for unhandled column type
* @throws SQLException SQL exception
*/
- default Object getDefaultValue(ResultSet resultSet, int columnIndex, int
columnType) throws SQLException {
+ default Object getDefaultValue(final ResultSet resultSet, final int
columnIndex, final int columnType) throws SQLException {
return resultSet.getObject(columnIndex);
}
}
diff --git a/docs/community/content/involved/contribute/dev-env.cn.md
b/docs/community/content/involved/contribute/dev-env.cn.md
index c7b1203115f..295fa260c50 100644
--- a/docs/community/content/involved/contribute/dev-env.cn.md
+++ b/docs/community/content/involved/contribute/dev-env.cn.md
@@ -81,4 +81,4 @@ git config --global core.longpaths true
### CheckStyle 插件配置
1. 添加配置文件 :使用 `src/resources/checkstyle.xml`;
-2. 选择 Checkstyle 版本 :使用 `9.3`。
+2. 选择 Checkstyle 版本 :使用 `12.3.0`。
diff --git a/docs/community/content/involved/contribute/dev-env.en.md
b/docs/community/content/involved/contribute/dev-env.en.md
index b69b284d9a3..ac1deb8aed0 100644
--- a/docs/community/content/involved/contribute/dev-env.en.md
+++ b/docs/community/content/involved/contribute/dev-env.en.md
@@ -81,4 +81,4 @@ These plugins might be useful for you:
### CheckStyle Settings
1. Add `Configuration File` : use `src/resources/checkstyle.xml`
-2. Select `Checkstyle version` : use `9.3`
+2. Select `Checkstyle version` : use `12.3.0`
diff --git
a/infra/algorithm/type/load-balancer/spi/src/main/java/org/apache/shardingsphere/infra/algorithm/loadbalancer/spi/LoadBalanceAlgorithm.java
b/infra/algorithm/type/load-balancer/spi/src/main/java/org/apache/shardingsphere/infra/algorithm/loadbalancer/spi/LoadBalanceAlgorithm.java
index 9efac43e895..3ba7fdad6e6 100644
---
a/infra/algorithm/type/load-balancer/spi/src/main/java/org/apache/shardingsphere/infra/algorithm/loadbalancer/spi/LoadBalanceAlgorithm.java
+++
b/infra/algorithm/type/load-balancer/spi/src/main/java/org/apache/shardingsphere/infra/algorithm/loadbalancer/spi/LoadBalanceAlgorithm.java
@@ -33,7 +33,7 @@ public interface LoadBalanceAlgorithm extends
ShardingSphereAlgorithm {
* @param databaseName database name
* @param configuredTargetNames configured target names
*/
- default void check(String databaseName, Collection<String>
configuredTargetNames) {
+ default void check(final String databaseName, final Collection<String>
configuredTargetNames) {
}
/**
diff --git
a/infra/distsql-handler/src/main/java/org/apache/shardingsphere/distsql/handler/engine/update/rdl/rule/spi/global/GlobalRuleDefinitionExecutor.java
b/infra/distsql-handler/src/main/java/org/apache/shardingsphere/distsql/handler/engine/update/rdl/rule/spi/global/GlobalRuleDefinitionExecutor.java
index 521d814cb79..e586d5527c8 100644
---
a/infra/distsql-handler/src/main/java/org/apache/shardingsphere/distsql/handler/engine/update/rdl/rule/spi/global/GlobalRuleDefinitionExecutor.java
+++
b/infra/distsql-handler/src/main/java/org/apache/shardingsphere/distsql/handler/engine/update/rdl/rule/spi/global/GlobalRuleDefinitionExecutor.java
@@ -38,7 +38,7 @@ public interface GlobalRuleDefinitionExecutor<T extends
GlobalRuleDefinitionStat
*
* @param sqlStatement SQL statement
*/
- default void checkBeforeUpdate(T sqlStatement) {
+ default void checkBeforeUpdate(final T sqlStatement) {
}
/**
diff --git
a/infra/util/src/main/java/org/apache/shardingsphere/infra/util/directory/ClasspathResourceDirectoryReader.java
b/infra/util/src/main/java/org/apache/shardingsphere/infra/util/directory/ClasspathResourceDirectoryReader.java
index 0c640e5ba11..4a7ed7affa4 100644
---
a/infra/util/src/main/java/org/apache/shardingsphere/infra/util/directory/ClasspathResourceDirectoryReader.java
+++
b/infra/util/src/main/java/org/apache/shardingsphere/infra/util/directory/ClasspathResourceDirectoryReader.java
@@ -86,11 +86,9 @@ public final class ClasspathResourceDirectoryReader {
/**
* Return a lazily populated Stream that contains the names of resources
in the provided directory. The Stream is recursive, meaning it includes
resources from all subdirectories as well.
- * <p>The name of a resource directory is a /-separated path name</p>
- * <p>When the {@code directory} parameter is a file, the method can still
work.</p>
*
* @param directory directory
- * @return resource iterator.
+ * @return resource iterator
* @apiNote This method must be used within a try-with-resources statement
or similar
* control structure to ensure that the stream's open resources
are closed
* promptly after the stream's operations have completed.
@@ -101,12 +99,10 @@ public final class ClasspathResourceDirectoryReader {
/**
* Return a lazily populated Stream that contains the names of resources
in the provided directory. The Stream is recursive, meaning it includes
resources from all subdirectories as well.
- * <p>The name of a resource directory is a /-separated path name</p>
- * <p>When the {@code directory} parameter is a file, the method can still
work.</p>
*
* @param classLoader class loader
* @param directory directory
- * @return resource iterator.
+ * @return resource iterator
* @apiNote This method must be used within a try-with-resources statement
or similar
* control structure to ensure that the stream's open resources
are closed
* promptly after the stream's operations have completed.
diff --git a/pom.xml b/pom.xml
index 38f6baba213..c3b2c3fea5f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -175,7 +175,7 @@
<apache-rat-plugin.version>0.15</apache-rat-plugin.version>
<spotless-maven-plugin.version>2.46.1</spotless-maven-plugin.version>
<maven-checkstyle-plugin.version>3.6.0</maven-checkstyle-plugin.version>
- <checkstyle.version>10.17.0</checkstyle.version>
+ <checkstyle.version>12.3.0</checkstyle.version>
<maven-pmd-plugin.version>3.20.0</maven-pmd-plugin.version>
<spotbugs-maven-plugin.version>4.7.2.1</spotbugs-maven-plugin.version>
<fb-contrib.version>7.6.0</fb-contrib.version>
diff --git a/src/resources/checkstyle.xml b/src/resources/checkstyle.xml
index 41a4661cfea..d5340e34c58 100644
--- a/src/resources/checkstyle.xml
+++ b/src/resources/checkstyle.xml
@@ -164,10 +164,6 @@
</module>
<module name="JavadocMissingLeadingAsterisk" />
<module name="JavadocMissingWhitespaceAfterAsterisk" />
- <module name="JavadocParagraph">
- <property name="violateExecutionOnNonTightHtml" value="true" />
- <property name="allowNewlineParagraph" value="false" />
- </module>
<module name="JavadocStyle" />
<module name="JavadocTagContinuationIndentation">
<property name="violateExecutionOnNonTightHtml" value="true" />