This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 3734ddfd235 Use @RequiredArgsConstructor (#37670)
3734ddfd235 is described below
commit 3734ddfd23580db8c77dde5c10ff3ab43e343252
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Jan 7 14:37:38 2026 +0800
Use @RequiredArgsConstructor (#37670)
* Use @RequiredArgsConstructor
* Use @RequiredArgsConstructor
---
.../firebird/metadata/data/loader/FirebirdColumnSizeLoader.java | 6 ++----
.../encrypt/metadata/reviser/column/EncryptColumnNameReviser.java | 6 ++----
.../token/generator/select/EncryptGroupByItemTokenGenerator.java | 6 ++----
.../postgresql/ingest/incremental/wal/WALEventConverter.java | 7 ++-----
.../updatable/UnregisterMigrationSourceStorageUnitStatement.java | 6 ++----
.../test/natived/commons/repository/AddressRepository.java | 6 ++----
.../test/natived/commons/repository/OrderItemRepository.java | 6 ++----
.../test/natived/commons/repository/OrderRepository.java | 6 ++----
8 files changed, 16 insertions(+), 33 deletions(-)
diff --git
a/database/connector/dialect/firebird/src/main/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/loader/FirebirdColumnSizeLoader.java
b/database/connector/dialect/firebird/src/main/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/loader/FirebirdColumnSizeLoader.java
index e0231e0a5ff..aa880082b15 100644
---
a/database/connector/dialect/firebird/src/main/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/loader/FirebirdColumnSizeLoader.java
+++
b/database/connector/dialect/firebird/src/main/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/loader/FirebirdColumnSizeLoader.java
@@ -17,6 +17,7 @@
package
org.apache.shardingsphere.database.connector.firebird.metadata.data.loader;
+import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.database.connector.core.metadata.data.loader.MetaDataLoaderConnection;
import
org.apache.shardingsphere.database.connector.core.metadata.data.loader.MetaDataLoaderMaterial;
import
org.apache.shardingsphere.database.connector.core.type.DatabaseTypeRegistry;
@@ -34,6 +35,7 @@ import java.util.Objects;
/**
* Loader for Firebird column sizes.
*/
+@RequiredArgsConstructor
final class FirebirdColumnSizeLoader {
private static final String LOAD_BLOB_SEGMENT_SIZES_SQL = "SELECT
TRIM(rf.RDB$FIELD_NAME) AS COLUMN_NAME, "
@@ -45,10 +47,6 @@ final class FirebirdColumnSizeLoader {
private final MetaDataLoaderMaterial material;
- FirebirdColumnSizeLoader(final MetaDataLoaderMaterial material) {
- this.material = material;
- }
-
Map<String, Map<String, Integer>> load() throws SQLException {
if (material.getActualTableNames().isEmpty()) {
return Collections.emptyMap();
diff --git
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/metadata/reviser/column/EncryptColumnNameReviser.java
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/metadata/reviser/column/EncryptColumnNameReviser.java
index b5604e5b608..c04ecb7c540 100644
---
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/metadata/reviser/column/EncryptColumnNameReviser.java
+++
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/metadata/reviser/column/EncryptColumnNameReviser.java
@@ -17,20 +17,18 @@
package org.apache.shardingsphere.encrypt.metadata.reviser.column;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.encrypt.rule.table.EncryptTable;
import
org.apache.shardingsphere.infra.metadata.database.schema.reviser.column.ColumnNameReviser;
/**
* Encrypt column name reviser.
*/
+@RequiredArgsConstructor
public final class EncryptColumnNameReviser implements ColumnNameReviser {
private final EncryptTable encryptTable;
- public EncryptColumnNameReviser(final EncryptTable encryptTable) {
- this.encryptTable = encryptTable;
- }
-
@Override
public String revise(final String originalName) {
if (encryptTable.isCipherColumn(originalName)) {
diff --git
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/select/EncryptGroupByItemTokenGenerator.java
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/select/EncryptGroupByItemTokenGenerator.java
index b25d5a663bf..1e68fecd904 100644
---
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/select/EncryptGroupByItemTokenGenerator.java
+++
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/select/EncryptGroupByItemTokenGenerator.java
@@ -17,6 +17,7 @@
package org.apache.shardingsphere.encrypt.rewrite.token.generator.select;
+import lombok.RequiredArgsConstructor;
import lombok.Setter;
import
org.apache.shardingsphere.database.connector.core.metadata.database.enums.QuoteCharacter;
import org.apache.shardingsphere.database.connector.core.type.DatabaseType;
@@ -48,15 +49,12 @@ import java.util.Optional;
* Group by item token generator for encrypt.
*/
@HighFrequencyInvocation
+@RequiredArgsConstructor
@Setter
public final class EncryptGroupByItemTokenGenerator implements
CollectionSQLTokenGenerator<SelectStatementContext> {
private final EncryptRule rule;
- public EncryptGroupByItemTokenGenerator(final EncryptRule rule) {
- this.rule = rule;
- }
-
@Override
public boolean isGenerateSQLToken(final SQLStatementContext
sqlStatementContext) {
return sqlStatementContext instanceof SelectStatementContext &&
containsGroupByItem((SelectStatementContext) sqlStatementContext);
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/wal/WALEventConverter.java
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/wal/WALEventConverter.java
index 459dedfecab..0f48322c2ee 100644
---
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/wal/WALEventConverter.java
+++
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/wal/WALEventConverter.java
@@ -17,6 +17,7 @@
package
org.apache.shardingsphere.data.pipeline.postgresql.ingest.incremental.wal;
+import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.data.pipeline.core.constant.PipelineSQLOperationType;
import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.IncrementalDumperContext;
import org.apache.shardingsphere.data.pipeline.core.ingest.record.Column;
@@ -40,17 +41,13 @@ import java.util.List;
/**
* WAL event converter.
*/
+@RequiredArgsConstructor
public final class WALEventConverter {
private final IncrementalDumperContext dumperContext;
private final PipelineTableMetaDataLoader metaDataLoader;
- public WALEventConverter(final IncrementalDumperContext dumperContext,
final PipelineTableMetaDataLoader metaDataLoader) {
- this.dumperContext = dumperContext;
- this.metaDataLoader = metaDataLoader;
- }
-
/**
* Convert WAL event to {@code Record}.
*
diff --git
a/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/UnregisterMigrationSourceStorageUnitStatement.java
b/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/UnregisterMigrationSourceStorageUnitStatement.java
index c082b96cf3a..8fdda88e1a7 100644
---
a/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/UnregisterMigrationSourceStorageUnitStatement.java
+++
b/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/UnregisterMigrationSourceStorageUnitStatement.java
@@ -18,6 +18,7 @@
package
org.apache.shardingsphere.data.pipeline.scenario.migration.distsql.statement.updatable;
import lombok.Getter;
+import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.data.pipeline.distsql.statement.updatable.UpdatablePipelineRALStatement;
import java.util.Collection;
@@ -25,12 +26,9 @@ import java.util.Collection;
/**
* Unregister migration source storage unit statement.
*/
+@RequiredArgsConstructor
@Getter
public final class UnregisterMigrationSourceStorageUnitStatement extends
UpdatablePipelineRALStatement {
private final Collection<String> names;
-
- public UnregisterMigrationSourceStorageUnitStatement(final
Collection<String> names) {
- this.names = names;
- }
}
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/AddressRepository.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/AddressRepository.java
index 1cfafac60ca..f8ef18c073a 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/AddressRepository.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/AddressRepository.java
@@ -17,6 +17,7 @@
package org.apache.shardingsphere.test.natived.commons.repository;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.test.natived.commons.entity.Address;
import javax.sql.DataSource;
@@ -28,15 +29,12 @@ import java.sql.Statement;
import java.util.LinkedList;
import java.util.List;
+@RequiredArgsConstructor
@SuppressWarnings({"SqlDialectInspection", "SqlNoDataSourceInspection"})
public final class AddressRepository {
private final DataSource dataSource;
- public AddressRepository(final DataSource dataSource) {
- this.dataSource = dataSource;
- }
-
/**
* Create table t_address if not exists in MySQL.
*
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java
index 909a4873e68..92f7df0acd1 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java
@@ -17,6 +17,7 @@
package org.apache.shardingsphere.test.natived.commons.repository;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.test.natived.commons.entity.OrderItem;
import javax.sql.DataSource;
@@ -31,15 +32,12 @@ import java.util.List;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
+@RequiredArgsConstructor
@SuppressWarnings({"SqlDialectInspection", "SqlNoDataSourceInspection"})
public final class OrderItemRepository {
private final DataSource dataSource;
- public OrderItemRepository(final DataSource dataSource) {
- this.dataSource = dataSource;
- }
-
/**
* create table if not exists in MySQL.
*
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderRepository.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderRepository.java
index f5be99d235a..b5178e7bed2 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderRepository.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderRepository.java
@@ -17,6 +17,7 @@
package org.apache.shardingsphere.test.natived.commons.repository;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.test.natived.commons.entity.Order;
import javax.sql.DataSource;
@@ -28,15 +29,12 @@ import java.sql.Statement;
import java.util.LinkedList;
import java.util.List;
+@RequiredArgsConstructor
@SuppressWarnings({"SqlDialectInspection", "SqlNoDataSourceInspection"})
public final class OrderRepository {
private final DataSource dataSource;
- public OrderRepository(final DataSource dataSource) {
- this.dataSource = dataSource;
- }
-
/**
* Create table if not exists in MySQL.
*