zxs1633079383 commented on PR #37259: URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3728284816
Hi @terrymanu , Thank you again for your guidance. I would like to provide an update regarding this PR: Scope / commit history This PR is focused strictly on UDT-related changes. Unrelated commits (e.g., checkstyle config reformatting, sample YAML) have been avoided. Please let me know if you prefer me to squash or reorganize the commits further. Mutable enum state The previous withTypeName() usage has been fully removed. No enum mutation remains; the typeName pipeline is now completely stateless and thread-safe. Types.OTHER / JSON / JSONB behavior Current behavior: UDTs remain Types.OTHER in metadata. JSON → "json" JSONB → "jsonb" JSON / JSONB bypass UDT logic. Other Types.OTHER uses normal fallback. No UDT_GENERIC mapping is included in this PR. UDT discovery UDT scanning improvements included: Enable/disable option Optional caching Protocol behavior handling The updates clarify scope/configuration and improve UDT handling without extra catalog queries. Tests All missing tests for UDT bind/describe/execute, JSON / JSONB, and non-UDT Types.OTHER have now been added. Minimal reproducible scenarios are included. Checkstyle / CI considerations Due to recent changes in checkstyle.xml, many legacy files now violate the updated rules. Running ./mvnw spotless:apply -Pcheck currently produces 700+ violations in a single module, which blocks automatic formatting. All functional tests pass successfully with ./mvnw clean install. For CI, please advise if there are any additional build or verification steps you would like me to include before merging. Thanks again for your time and guidance. <img width="1826" height="614" alt="image" src="https://github.com/user-attachments/assets/34b3b533-5a02-4c16-a8e4-71ae2334d24c"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
