[GitHub] [shardingsphere] terrymanu commented on a change in pull request #5614: Use YAML file instead of inline string in ConfigCenterTest.java

[GitBox]

terrymanu commented on a change in pull request #5614:
URL: https://github.com/apache/shardingsphere/pull/5614#discussion_r425572207



##########
File path: 
sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/test/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenterTest.java
##########
@@ -552,4 +465,13 @@ private void 
assertDataSourceConfigurationWithConnectionInitSqls(final DataSourc
         assertThat(actual.getProperties().get("password"), 
is(expected.getProperties().get("password")));
         assertThat(actual.getProperties().get("connectionInitSqls"), 
is(expected.getProperties().get("connectionInitSqls")));
     }
+
+    private static String readYamlFileIntoString(final String fileName) {
+        try {
+            return (new 
String(Files.readAllBytes(Paths.get(ClassLoader.getSystemResource(fileName).toURI())))).replaceAll("#.*\n",
 "");

Review comment:
       Could we let snake yaml to process comments and make our code simpler?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org