This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 1887db9f289 Fix sonar issue on StorageUnitManagerTest (#37989)
1887db9f289 is described below
commit 1887db9f289a9a94d7778136f2c1c2f24fbfae6c
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Feb 9 00:11:30 2026 +0800
Fix sonar issue on StorageUnitManagerTest (#37989)
---
.../mode/metadata/manager/resource/StorageUnitManagerTest.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/manager/resource/StorageUnitManagerTest.java
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/manager/resource/StorageUnitManagerTest.java
index d798e957ae7..186d8a0524b 100644
---
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/manager/resource/StorageUnitManagerTest.java
+++
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/manager/resource/StorageUnitManagerTest.java
@@ -45,7 +45,6 @@ import static
org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.lenient;
@@ -73,7 +72,7 @@ class StorageUnitManagerTest {
when(reloadMetaDataContexts.getMetaData().getDatabase(DATABASE_NAME)).thenReturn(reloadDatabase);
try (
MockedConstruction<MetaDataContextsFactory> ignored =
mockConstruction(MetaDataContextsFactory.class,
- (mock, context) ->
when(mock.createBySwitchResource(eq(DATABASE_NAME), eq(true),
eq(switchingResource),
eq(metaDataContexts))).thenReturn(reloadMetaDataContexts))) {
+ (mock, context) ->
when(mock.createBySwitchResource(DATABASE_NAME, true, switchingResource,
metaDataContexts)).thenReturn(reloadMetaDataContexts))) {
createManager(metaDataContexts,
resourceSwitchManager).register(DATABASE_NAME, Collections.emptyMap());
}
verify(metaDataContexts).update(any(MetaDataContexts.class));
@@ -105,7 +104,7 @@ class StorageUnitManagerTest {
when(reloadDatabase.getAllSchemas()).thenReturn(Collections.singleton(new
ShardingSphereSchema("foo_schema", mock(DatabaseType.class))));
try (
MockedConstruction<MetaDataContextsFactory> ignored =
mockConstruction(MetaDataContextsFactory.class,
- (mock, context) ->
when(mock.createBySwitchResource(eq(DATABASE_NAME), eq(true),
eq(switchingResource),
eq(metaDataContexts))).thenReturn(reloadMetaDataContexts))) {
+ (mock, context) ->
when(mock.createBySwitchResource(DATABASE_NAME, true, switchingResource,
metaDataContexts)).thenReturn(reloadMetaDataContexts))) {
createManager(metaDataContexts,
resourceSwitchManager).alter(DATABASE_NAME, Collections.emptyMap());
}
verify(metaDataContexts).update(any(MetaDataContexts.class));
@@ -136,7 +135,7 @@ class StorageUnitManagerTest {
when(reloadDatabase.getAllSchemas()).thenReturn(Collections.singleton(new
ShardingSphereSchema("foo_schema", mock(DatabaseType.class))));
try (
MockedConstruction<MetaDataContextsFactory> ignored =
mockConstruction(MetaDataContextsFactory.class,
- (mock, context) ->
when(mock.createBySwitchResource(eq(DATABASE_NAME), eq(false),
eq(switchingResource),
eq(metaDataContexts))).thenReturn(reloadMetaDataContexts))) {
+ (mock, context) ->
when(mock.createBySwitchResource(DATABASE_NAME, false, switchingResource,
metaDataContexts)).thenReturn(reloadMetaDataContexts))) {
createManager(metaDataContexts,
resourceSwitchManager).unregister(DATABASE_NAME, "ds_0");
}
verify(metaDataContexts).update(any(MetaDataContexts.class));