(shardingsphere) branch master updated: Refactor ImportMetaDataExecutorTest (#38028)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 3f56bdc8c63 Refactor ImportMetaDataExecutorTest (#38028)
3f56bdc8c63 is described below

commit 3f56bdc8c63eae8764421dae4dc027be76a2cf36
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Fri Feb 13 00:36:01 2026 +0800

    Refactor ImportMetaDataExecutorTest (#38028)
---
 .../ral/updatable/imports/ImportMetaDataExecutorTest.java   | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/imports/ImportMetaDataExecutorTest.java
 
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/imports/ImportMetaDataExecutorTest.java
index 54ce4b74312..cffe8c205d7 100644
--- 
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/imports/ImportMetaDataExecutorTest.java
+++ 
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/imports/ImportMetaDataExecutorTest.java
@@ -104,18 +104,17 @@ class ImportMetaDataExecutorTest {
     
     @Test
     void assertExecuteUpdateFromJsonValue() {
-        ContextManager contextManager = 
createContextManagerWithTemporaryProps();
+        ContextManager contextManager = mockContextManager();
         executor.executeUpdate(new 
ImportMetaDataStatement(Base64.encodeBase64String(METADATA_VALUE.getBytes(StandardCharsets.UTF_8)),
 null), contextManager);
         assertNotNull(contextManager.getDatabase("normal_db"));
     }
     
     private static Stream<Arguments> importFailureCases() {
         return Stream.of(
-                Arguments.of("import empty metadata", 
createImportMetaDataStatement(EMPTY_METADATA_FILE_PATH), 
createContextManagerWithTemporaryProps(), EmptyStorageUnitException.class),
-                Arguments.of("import existed metadata", 
createImportMetaDataStatement(EMPTY_METADATA_FILE_PATH), 
createContextManagerWithExistedDatabase(),
-                        DatabaseCreateExistsException.class),
-                Arguments.of("import metadata from missing file", new 
ImportMetaDataStatement(null, NOT_EXIST_METADATA_FILE_PATH), 
mock(ContextManager.class), FileIOException.class),
-                Arguments.of("import metadata with empty file path in file 
branch", createStatementWithEmptyFilePathInFileBranch(), 
mock(ContextManager.class), JsonProcessingException.class));
+                Arguments.of("import empty metadata", 
createImportMetaDataStatement(EMPTY_METADATA_FILE_PATH), mockContextManager(), 
EmptyStorageUnitException.class),
+                Arguments.of("import existed metadata", 
createImportMetaDataStatement(EMPTY_METADATA_FILE_PATH), 
createContextManagerWithExistedDatabase(), DatabaseCreateExistsException.class),
+                Arguments.of("import metadata from missing file", new 
ImportMetaDataStatement(null, NOT_EXIST_METADATA_FILE_PATH), 
mockContextManager(), FileIOException.class),
+                Arguments.of("import metadata with empty file path in file 
branch", createStatementWithEmptyFilePathInFileBranch(), mockContextManager(), 
JsonProcessingException.class));
     }
     
     private static ImportMetaDataStatement createImportMetaDataStatement(final 
String filePath) {
@@ -131,7 +130,7 @@ class ImportMetaDataExecutorTest {
         return result;
     }
     
-    private static ContextManager createContextManagerWithTemporaryProps() {
+    private static ContextManager mockContextManager() {
         ContextManager result = mock(ContextManager.class, RETURNS_DEEP_STUBS);
         
when(result.getMetaDataContexts().getMetaData().getTemporaryProps()).thenReturn(new
 TemporaryConfigurationProperties(new Properties()));
         return result;