strongduanmu commented on code in PR #38032:
URL: https://github.com/apache/shardingsphere/pull/38032#discussion_r2806792453
##########
test/it/parser/src/main/resources/sql/supported/dal/set.xml:
##########
@@ -50,4 +50,6 @@
<sql-case id="set_session_authorization" value="SET SESSION AUTHORIZATION
user1 PASSWORD 'password'" db-types="openGauss" />
<sql-case id="set_persist_system_variable_doris" value="SET PERSIST
max_connections = 200" db-types="Doris" />
<sql-case id="set_persist_only_system_variable_doris" value="SET
PERSIST_ONLY time_zone = '+08:00'" db-types="Doris" />
+ <sql-case id="set_mysql_version_comment" value="/*! SET GLOBAL
max_connections=123 */" db-types="MySQL" />
+ <sql-case id="set_mysql_version_comment_with_version" value="/*!80029 SET
GLOBAL max_connections=456 */" db-types="MySQL" />
Review Comment:
Can you add parse comment into SQLStatement comments? And add assert for
comments field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
