manasagar commented on PR #37965: URL: https://github.com/apache/shardingsphere/pull/37965#issuecomment-3908002537
@terrymanu sorry about the delay Type domain mismatch — Switching to java.sql.Types constants resolves the JDBC-vs-OID mismatch. This should now correctly route timestamp/time values through the formatting logic. Fixed in: database/protocol/dialect/postgresql/src/main/java/org/apache/shardingsphere/database/protocol/postgresql/packet/command/query/PostgreSQLDataRowPacket.java NPE risk — Moving columnTypes initialization into execute() ensures the array is always populated before row packet generation, eliminating the null reference path. Fixed in: proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/Portal.java Time zone handling — Changing from ZoneOffset.UTC to ZoneId.systemDefault() is a step in the right direction. Changed in: database/protocol/dialect/postgresql/src/main/java/org/apache/shardingsphere/database/protocol/postgresql/packet/command/query/PostgreSQLDataRowPacket.java:138 .I am unclear what you mean incorrect processing of timestamp for timestamptz . Timestamp does not possess any information regarding timezones so I decided to use systemDefault but this seems to be causing it to fail on some testcases the alternative would be to simply add +00:00 every time their is a timestamp in timstamptz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
