(shardingsphere) branch master updated: Add more test cases on SingleSupportedSQLCheckersBuilderTest (#38077)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new af0f3d0538f Add more test cases on 
SingleSupportedSQLCheckersBuilderTest (#38077)
af0f3d0538f is described below

commit af0f3d0538fd47c2037cd2584e11fcb0e9d115de
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Wed Feb 18 01:05:37 2026 +0800

    Add more test cases on SingleSupportedSQLCheckersBuilderTest (#38077)
    
    * Add more test cases on SingleSupportedSQLCheckersBuilderTest
    
    * Add more test cases on SingleSupportedSQLCheckersBuilderTest
---
 .../sql/SingleSupportedSQLCheckersBuilder.java     |  4 +--
 .../SingleSupportedSQLCheckersBuilderTest.java}    | 42 +++++++++-------------
 2 files changed, 18 insertions(+), 28 deletions(-)

diff --git 
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
 
b/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
index bd71c471095..ec51bc70def 100644
--- 
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
+++ 
b/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
@@ -33,9 +33,7 @@ import java.util.Collection;
  */
 public final class SingleSupportedSQLCheckersBuilder implements 
SupportedSQLCheckersBuilder<SingleRule> {
     
-    private final Collection<SupportedSQLChecker<?, SingleRule>> 
supportedSQLCheckers = Arrays.asList(
-            new SingleDropSchemaSupportedChecker(),
-            new SingleDropTableSupportedChecker());
+    private final Collection<SupportedSQLChecker<?, SingleRule>> 
supportedSQLCheckers = Arrays.asList(new SingleDropSchemaSupportedChecker(), 
new SingleDropTableSupportedChecker());
     
     @HighFrequencyInvocation
     @Override
diff --git 
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
 
b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilderTest.java
similarity index 57%
copy from 
kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
copy to 
kernel/single/core/src/test/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilderTest.java
index bd71c471095..248d900031b 100644
--- 
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilder.java
+++ 
b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/checker/sql/SingleSupportedSQLCheckersBuilderTest.java
@@ -17,39 +17,31 @@
 
 package org.apache.shardingsphere.single.checker.sql;
 
-import org.apache.shardingsphere.infra.annotation.HighFrequencyInvocation;
 import org.apache.shardingsphere.infra.checker.SupportedSQLChecker;
 import org.apache.shardingsphere.infra.checker.SupportedSQLCheckersBuilder;
+import org.apache.shardingsphere.infra.spi.type.ordered.OrderedSPILoader;
 import 
org.apache.shardingsphere.single.checker.sql.schema.SingleDropSchemaSupportedChecker;
 import 
org.apache.shardingsphere.single.checker.sql.table.SingleDropTableSupportedChecker;
-import org.apache.shardingsphere.single.constant.SingleOrder;
 import org.apache.shardingsphere.single.rule.SingleRule;
+import org.junit.jupiter.api.Test;
 
-import java.util.Arrays;
-import java.util.Collection;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
 
-/**
- * Single SQL supported checker factory.
- */
-public final class SingleSupportedSQLCheckersBuilder implements 
SupportedSQLCheckersBuilder<SingleRule> {
-    
-    private final Collection<SupportedSQLChecker<?, SingleRule>> 
supportedSQLCheckers = Arrays.asList(
-            new SingleDropSchemaSupportedChecker(),
-            new SingleDropTableSupportedChecker());
-    
-    @HighFrequencyInvocation
-    @Override
-    public Collection<SupportedSQLChecker<?, SingleRule>> 
getSupportedSQLCheckers() {
-        return supportedSQLCheckers;
-    }
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.isA;
+
+class SingleSupportedSQLCheckersBuilderTest {
     
-    @Override
-    public int getOrder() {
-        return SingleOrder.ORDER;
-    }
+    @SuppressWarnings("rawtypes")
+    private final SupportedSQLCheckersBuilder builder = 
OrderedSPILoader.getServicesByClass(SupportedSQLCheckersBuilder.class, 
Collections.singleton(SingleRule.class)).get(SingleRule.class);
     
-    @Override
-    public Class<SingleRule> getTypeClass() {
-        return SingleRule.class;
+    @SuppressWarnings("unchecked")
+    @Test
+    void assertGetSupportedSQLCheckers() {
+        List<SupportedSQLChecker<?, SingleRule>> actual = new 
ArrayList<SupportedSQLChecker<?, 
SingleRule>>(builder.getSupportedSQLCheckers());
+        assertThat(actual.get(0), isA(SingleDropSchemaSupportedChecker.class));
+        assertThat(actual.get(1), isA(SingleDropTableSupportedChecker.class));
     }
 }