(shardingsphere) branch master updated: Add more test cases on PostgreSQLSystemDatabaseTest (#38142)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 14b7f90813c Add more test cases on PostgreSQLSystemDatabaseTest 
(#38142)
14b7f90813c is described below

commit 14b7f90813cd6bd68dde3551a9e1617d06b075d5
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sun Feb 22 19:09:40 2026 +0800

    Add more test cases on PostgreSQLSystemDatabaseTest (#38142)
---
 .../system/PostgreSQLSystemDatabaseTest.java       | 30 ++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git 
a/database/connector/dialect/postgresql/src/test/java/org/apache/shardingsphere/database/connector/postgresql/metadata/database/system/PostgreSQLSystemDatabaseTest.java
 
b/database/connector/dialect/postgresql/src/test/java/org/apache/shardingsphere/database/connector/postgresql/metadata/database/system/PostgreSQLSystemDatabaseTest.java
index 70b00befe24..8373647522d 100644
--- 
a/database/connector/dialect/postgresql/src/test/java/org/apache/shardingsphere/database/connector/postgresql/metadata/database/system/PostgreSQLSystemDatabaseTest.java
+++ 
b/database/connector/dialect/postgresql/src/test/java/org/apache/shardingsphere/database/connector/postgresql/metadata/database/system/PostgreSQLSystemDatabaseTest.java
@@ -22,18 +22,44 @@ import 
org.apache.shardingsphere.database.connector.core.spi.DatabaseTypedSPILoa
 import org.apache.shardingsphere.database.connector.core.type.DatabaseType;
 import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 
 import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.stream.Stream;
 
-import static org.hamcrest.Matchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
 
 class PostgreSQLSystemDatabaseTest {
     
-    private final DialectSystemDatabase systemDatabase = 
DatabaseTypedSPILoader.getService(DialectSystemDatabase.class, 
TypedSPILoader.getService(DatabaseType.class, "PostgreSQL"));
+    private final DatabaseType databaseType = 
TypedSPILoader.getService(DatabaseType.class, "PostgreSQL");
+    
+    private final DialectSystemDatabase systemDatabase = 
DatabaseTypedSPILoader.getService(DialectSystemDatabase.class, databaseType);
+    
+    @Test
+    void assertGetSystemDatabases() {
+        assertThat(systemDatabase.getSystemDatabases(), 
is(Collections.singleton("postgres")));
+    }
+    
+    @ParameterizedTest(name = "{0}")
+    @MethodSource("getSystemSchemasWithDatabaseNameArguments")
+    void assertGetSystemSchemasWithDatabaseName(final String name, final 
String databaseName, final Collection<String> expectedSchemas) {
+        assertThat(systemDatabase.getSystemSchemas(databaseName), 
is(expectedSchemas));
+    }
     
     @Test
     void assertGetSystemSchemas() {
         assertThat(systemDatabase.getSystemSchemas(), 
is(Arrays.asList("information_schema", "pg_catalog", "shardingsphere")));
     }
+    
+    private static Stream<Arguments> 
getSystemSchemasWithDatabaseNameArguments() {
+        return Stream.of(
+                Arguments.of("existing database", "postgres", 
Arrays.asList("information_schema", "pg_catalog", "shardingsphere")),
+                Arguments.of("non-existing database", "foo", 
Collections.emptyList()),
+                Arguments.of("null database", null, Collections.emptyList()));
+    }
 }