(shardingsphere) branch master updated: Refactor constructor of RenameTableStatement to empty buildAttributes (#38347)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new abe531f99a5 Refactor constructor of RenameTableStatement to empty 
buildAttributes (#38347)
abe531f99a5 is described below

commit abe531f99a57137a0f8c8103fa486ad19cfdeb53
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Wed Mar 4 23:25:32 2026 +0800

    Refactor constructor of RenameTableStatement to empty buildAttributes 
(#38347)
---
 .../statement/ddl/PrepareStatementBinderTest.java      |  4 ++--
 .../statement/type/ddl/table/RenameTableStatement.java | 18 +++++++++++-------
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git 
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/PrepareStatementBinderTest.java
 
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/PrepareStatementBinderTest.java
index 52bd5d8c2e0..db8062550e7 100644
--- 
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/PrepareStatementBinderTest.java
+++ 
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/statement/ddl/PrepareStatementBinderTest.java
@@ -73,7 +73,7 @@ class PrepareStatementBinderTest {
         when(table.getAllColumns()).thenReturn(Collections.emptyList());
         HintValueContext hintValueContext = new HintValueContext();
         hintValueContext.setSkipMetadataValidate(true);
-        final PrepareStatement prepareStatement = 
PrepareStatement.builder().databaseType(databaseType).select(createSelectStatement()).build();
+        PrepareStatement prepareStatement = 
PrepareStatement.builder().databaseType(databaseType).select(createSelectStatement()).build();
         SQLStatementBinderContext binderContext = new 
SQLStatementBinderContext(metaData, "foo_db_1", hintValueContext, 
prepareStatement);
         PrepareStatement actual = new 
PrepareStatementBinder().bind(prepareStatement, binderContext);
         assertThat(actual.getDatabaseType(), is(databaseType));
@@ -87,7 +87,7 @@ class PrepareStatementBinderTest {
     void assertBindWithoutInnerStatements() {
         HintValueContext hintValueContext = new HintValueContext();
         hintValueContext.setSkipMetadataValidate(true);
-        final PrepareStatement prepareStatement = 
PrepareStatement.builder().databaseType(databaseType).build();
+        PrepareStatement prepareStatement = 
PrepareStatement.builder().databaseType(databaseType).build();
         SQLStatementBinderContext binderContext = new 
SQLStatementBinderContext(metaData, "foo_db_1", hintValueContext, 
prepareStatement);
         PrepareStatement actual = new 
PrepareStatementBinder().bind(prepareStatement, binderContext);
         assertThat(actual.getDatabaseType(), is(databaseType));
diff --git 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/RenameTableStatement.java
 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/RenameTableStatement.java
index 463d8c8ab24..15a2ff211b5 100644
--- 
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/RenameTableStatement.java
+++ 
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/RenameTableStatement.java
@@ -36,20 +36,24 @@ public final class RenameTableStatement extends 
DDLStatement {
     
     private final Collection<RenameTableDefinitionSegment> renameTables;
     
-    private SQLStatementAttributes attributes;
+    private final SQLStatementAttributes attributes;
     
     public RenameTableStatement(final DatabaseType databaseType, final 
Collection<RenameTableDefinitionSegment> renameTables) {
         super(databaseType);
         this.renameTables = renameTables;
+        attributes = new SQLStatementAttributes(new 
TableSQLStatementAttribute(getTables(renameTables)));
     }
     
-    @Override
-    public void buildAttributes() {
-        Collection<SimpleTableSegment> tables = new LinkedList<>();
+    private Collection<SimpleTableSegment> getTables(final 
Collection<RenameTableDefinitionSegment> renameTables) {
+        Collection<SimpleTableSegment> result = new LinkedList<>();
         for (RenameTableDefinitionSegment each : renameTables) {
-            tables.add(each.getTable());
-            tables.add(each.getRenameTable());
+            result.add(each.getTable());
+            result.add(each.getRenameTable());
         }
-        attributes = new SQLStatementAttributes(new 
TableSQLStatementAttribute(tables));
+        return result;
+    }
+    
+    @Override
+    public void buildAttributes() {
     }
 }