ccxxxyy commented on PR #38368: URL: https://github.com/apache/shardingsphere/pull/38368#issuecomment-4018435987
@terrymanu Hi! Thank you very much for your reply and guidance. I would greatly appreciate it if you could take a moment to review the changes when you have time. Below is a summary of the modifications in this commit: - Moved the logic from `DorisLoadDataStatement`, `DorisLoadDataStatementAssert`, and `DorisLoadDataStatementTestCase` to `MySQLLoadDataStatement`, `MySQLLoadDataStatementAssert`, and `MySQLLoadDataStatementTestCase`, then deleted the original three Doris-related classes. - Restored the usage of MySQLLoadDataStatement in `DorisDMLStatementVisitor.java` - Updated the tag from </doris-load-data> to the correct </load-data> for Doris assertions in `src/main/resources/case/dml/load-data.xml`, making the assertion logic take effect and all assertion tests pass. - Fixed the Doris assertions in `test/it/binder/src/test/resources/cases/dml/load-data.xml` and added the necessary <table-bound> tags, so that the assertion tests pass and the original binder logic is restored. Please review the changes at your convenience. Thank you again for your corrections and time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
