strongduanmu commented on PR #38671:
URL: https://github.com/apache/shardingsphere/pull/38671#issuecomment-4385115527
• Merge Verdict: Mergeable
Reviewed Scope
- Latest PR head: 70b75e8f859fbd60d280110e79a0c14dbec4ebe7
- Files reviewed:
-
test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/env/container/compose/ContainerComposerRegistry.java
-
test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/env/DataSetEnvironmentManager.java
- E2E lifecycle callers: SQLE2EEnvironmentEngine, SQLE2EIT,
E2ETestParameter
- E2E SQL workflow commands
Not Reviewed Scope
- Full raw Docker logs for every E2E job.
- Non-SQL E2E modules beyond status checks.
Need Expert Review
- No.
Basis
- CI state rechecked: Required - Check, E2E - Operation, and E2E - SQL are
all completed/success.
- The changed path is SQL E2E test infrastructure only. No production
runtime path, parser behavior, dependency, config, API/SPI, or SQL semantics
changed.
- The lifecycle risk is acceptable after fresh review because test/e2e/sql
has no JUnit/failsafe parallel execution config; GitHub workflow matrix
parallelism runs separate jobs. Within a test invocation,
SQLE2EEnvironmentEngine obtains the composer before
invocation.proceed(), and E2E success validates actual Docker paths
across JDBC/Proxy, Standalone/Cluster, MySQL/PostgreSQL, and several feature
scenarios.
- close() now runs under synchronization and clears the registry
consistently. Same-key reuse remains unchanged; different-key replacement is
validated by the E2E SQL matrix.
- DataSetEnvironmentManager removing local final aligns with
CODE_OF_CONDUCT.md local-variable style, so I do not treat it as a blocker.
Pre-Merge Checks
- git diff --check HEAD^ HEAD: exit 0
- GitHub app: no PR comments, no review threads, no submitted reviews.
- Optional housekeeping: PR body still has Fixes #ISSUSE_ID; clean it
before merge if you want metadata tidy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
