menghaoranss commented on PR #38678: URL: https://github.com/apache/shardingsphere/pull/38678#issuecomment-4411176904
Merge Verdict: Mergeable Reviewed Scope: Latest head: 2c4f58459acf3d630c5f29f1bdeb41d1ff450b31 Files: infra/common/.../GenericSchemaBuilder.java infra/common/.../SchemaMetaDataUtils.java infra/common/.../SchemaMetaDataUtilsTest.java Shared-path blast-radius checked for both: same protocol/storage path (isSameProtocolAndStorageTypes=true) heterogeneous protocol/storage path (false, including mixed storage-unit case) Not Reviewed Scope: End-to-end JDBC/Proxy integration behavior outside unit-test scope Need Expert Review: No Basis Root-cause mapping is coherent: normalization is now conditional on protocol/storage heterogeneity, instead of always applying TABLE-scope normalization. this directly targets identifier normalization mismatch in heterogeneous metadata loading. Risk scan: Design/perf: change is minimal (boolean gate + localized normalize helper), no new hot-path complexity. Compatibility: behavior split by protocol/storage sameness is explicit and covered by tests. Regression/counterexample: same-type path keeps original actual names (non-target safety path) heterogeneous path still normalizes via identifier context mixed storage-unit scenario is explicitly covered in tests No unrelated file changes in this PR diff. Pre-merge checks Local scoped verification (with -am) passed: ./mvnw -pl infra/common -am -DskipITs -Dspotless.skip=true -Dtest=SchemaMetaDataUtilsTest -Dsurefire.failIfNoSpecifiedTests=false test (exit 0) Reviews/comments/status endpoints for this PR head are currently empty from API pulls; no blocking reviewer evidence found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
