strongduanmu commented on PR #38681:
URL: https://github.com/apache/shardingsphere/pull/38681#issuecomment-4412233225
Merge Verdict: Mergeable
Reviewed Scope: `ColumnExtractor` and `ColumnExtractorTest`.
Not Reviewed Scope: end-to-end SELECT extraction, parser visitor behavior,
and dialect-specific named window resolution.
Need Expert Review: No.
This change is focused and reasonable for
`ColumnExtractor.extract(ExpressionSegment)`. It adds traversal for window
function columns from:
- function / aggregation parameters
- `PARTITION BY`
- window `ORDER BY`
- frame clause expression
The added tests cover both `AggregationProjectionSegment` and
`FunctionSegment` with window metadata, including partition/order/frame
extraction. Existing no-window extraction behavior remains covered by the
current cases.
Pre-merge checks reviewed:
- GitHub CI on latest head: success
- Local targeted test: `./mvnw -pl parser/sql/statement/core -am -DskipITs
-Dspotless.skip=true -Dtest=ColumnExtractorTest
-Dsurefire.failIfNoSpecifiedTests=false test` passed
- Local Checkstyle: `./mvnw -pl parser/sql/statement/core -am -Pcheck
-DskipTests checkstyle:check` passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
