strongduanmu commented on PR #38689:
URL: https://github.com/apache/shardingsphere/pull/38689#issuecomment-4438021259
Merge Verdict: Mergeable
Reviewed Scope:
- Oracle parser grammar / visitor: MODEL, PIVOT/UNPIVOT, PIVOT XML, XML
functions, and hierarchical query.
- Binder core: binding paths for model, pivot, XML, and hierarchical query.
- Parser IT / Binder IT fixtures.
- GitHub Actions: CI, Required Check, and E2E all passed on the latest PR
head 69f5f70.
Basis:
- The Oracle syntax support is aligned with Oracle official documentation
for SELECT, PIVOT XML ANY, XMLSERIALIZE, and hierarchical query.
- The changes cover the main parser, visitor, AST, binder, and IT paths,
so this is not just fallback handling.
- Existing tests cover the major newly supported Oracle scenarios,
including model, pivot/unpivot, XML, hierarchical query, window, and CTE alias
cases.
- I did not find clear evidence that the PR directly breaks existing SQL
parsing or binding behavior.
Pre-merge checks:
- Visible GitHub Actions runs are successful.
- Keeping the current full CI result should be sufficient before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
