menghaoranss commented on PR #38691:
URL: https://github.com/apache/shardingsphere/pull/38691#issuecomment-4448481844
1. Decision
- `Merge Verdict: Mergeable`
- `Reviewed Scope`:
-
`mode/type/cluster/core/src/main/java/.../ClusterMetaDataManagerPersistService.java`
-
`mode/type/cluster/core/src/test/java/.../ClusterMetaDataManagerPersistServiceTest.java`
- PR metadata, file diff, reviews, and check-runs on latest head
`2c7c1ca8f4f38dd0799021ba40dcf1839c3bf759`
- `Not Reviewed Scope`:
- I did not re-run local Maven on this PR head; conclusion is based on
diff + CI evidence.
- I did not inspect every CI job log line-by-line.
- `Need Expert Review`: No
2. Basis
- Root-cause alignment is correct:
- The fix changes single-rule removal in cluster from using raw reloaded
database to `rebuildDatabaseSchemaIndex(...)` before
`persistReloadDatabaseByUnloadSingleTable(...)`.
- This directly addresses the previously identified mismatch where single
rule node was deleted but schema tables were not dropped.
- Design/risk assessment:
- Very small, targeted change (2 files, +17/-1).
- No unrelated code change found.
- No API/SPI contract expansion; behavior is made consistent with the new
two-phase schema handling direction.
- Adversarial pass (required):
- Cross-path risk: this change is cluster-only and limited to single-rule
remove path; no broader shared-parser/dialect logic touched.
- Feature-flag-off path: no new flag branch introduced.
- Original symptom path: covered by updated test setup for reloaded
metadata context and protocol type.
3. Pre-merge checks
- CI status on head commit: `total 36`, `success 35`, `skipped 1`, `failure
0`.
- PR reviews endpoint currently returns empty (no blocking review comments
visible).
- PR links:
- [PR 38691](https://github.com/apache/shardingsphere/pull/38691)
- [Files
API](https://api.github.com/repos/apache/shardingsphere/pulls/38691/files?per_page=100)
- [Checks
API](https://api.github.com/repos/apache/shardingsphere/commits/2c7c1ca8f4f38dd0799021ba40dcf1839c3bf759/check-runs?per_page=100)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
