strongduanmu commented on PR #38692:
URL: https://github.com/apache/shardingsphere/pull/38692#issuecomment-4448593249
Merge Verdict: Mergeable
Reviewed Scope
- PR latest head: e8a0baebd4de260cf95513df5a86484e96d8ab02
- 重点 reviewed：
- features/encrypt/core/.../EncryptConstants.java
- EncryptPredicateColumnSupportedChecker.java
- EncryptPredicateParameterRewriter.java
- EncryptPredicateColumnTokenGenerator.java
- EncryptPredicateValueTokenGenerator.java
- Oracle CONNECT_BY_* 同步改动按你的说明视为预期商业代码同步，本轮不作为阻塞项。
Basis
- LIKE / NOT LIKE 判断抽到 EncryptConstants.LIKE_OPERATORS，使用
CaseInsensitiveSet，保持原来的大小写不敏感语义。
- EncryptPredicateColumnTokenGenerator 中缓存 ColumnSegmentBoundInfo
只是减少重复调用，表/列查找、加密列判断、token 生成路径未改变。
- 加密谓词 checker、parameter rewriter、column/value token generator 的原有
assisted query、like query、cipher fallback 路径保持一致。
- 没看到性能、兼容性、禁用路径或相邻 = 谓词路径的新风险。
- CI、Required Check、CI、E2E SQL、E2E Operation、E2E Agent 均为 success。
可改成的 review 结论
Merge Verdict: Mergeable
The encrypt predicate refactor looks safe to merge. The LIKE / NOT LIKE
checks are centralized through a case-insensitive constant, preserving the
previous matching behavior. The ColumnSegmentBoundInfo extraction in
EncryptPredicateColumnTokenGenerator is an equivalent local cleanup and
does not change table/column lookup, fallback, or token generation semantics.
CI and E2E are green on the latest head. The Oracle CONNECT_BY_*
function-option sync is treated as expected scope for this PR per maintainer
context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
