FlyingZC commented on PR #38694:
URL: https://github.com/apache/shardingsphere/pull/38694#issuecomment-4456709828
Decision
- Merge Verdict: Mergeable
- Reviewed Scope：PR 最新 head
52f42b267c8cef61532ab36e655e9dfe8f4d6b21；jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/core/connection/ShardingSphereConnection.java
- Not Reviewed Scope：不把当前 pending CI 作为代码 review 阻塞项；最终合并前仍需等 GitHub jobs
全绿。
- Need Expert Review：No
Basis
该改动修复的是 close() 中分布式事务 rollback 失败会阻断后续资源关闭的问题。现在 rollback 失败只记录 warn
日志，并继续执行 connection/process/statement/physical connection 清理，符合
close() 场景下资源释放优先的语义。
代码范围小，无无关变更；非分布式事务路径不受影响；日志保留异常堆栈，便于排查。
Pre-merge Checks
- 本地验证已通过：./mvnw -pl jdbc -am -DskipITs -Dspotless.skip=true
-Dtest=ShardingSphereConnectionTest -Dsurefire.failIfNoSpecifiedTests=false test
- 合并前等待 GitHub CI/E2E 全部完成并通过。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
