menghaoranss commented on PR #38695: URL: https://github.com/apache/shardingsphere/pull/38695#issuecomment-4458242318
Merge Verdict: **Mergeable** Reviewed Scope: - `kernel/single/core/src/main/java/org/apache/shardingsphere/single/rule/attribute/SingleTableMapperRuleAttribute.java` - `kernel/single/core/src/test/java/org/apache/shardingsphere/single/rule/attribute/SingleTableMapperRuleAttributeTest.java` - Consumer-path spot check for `TableMapperRuleAttribute#getLogicTableNames()` in single rule flow. Not Reviewed Scope: - Full runtime integration replay on mixed JDBC/Proxy topologies in this round. Need Expert Review: - No additional expert gate required for this scoped change. Basis: - The stated goal is clear: single-table logical name matching should be case-insensitive to support cross-dialect access paths (for example, Oracle physical uppercase names accessed from MySQL-side lowercase SQL). - The patch directly updates logical table-name storage to case-insensitive semantics and aligns unit-test expectations with that behavior. - This is consistent with current single-rule matching behavior and avoids mismatch during kernel-level lookup when identifier casing differs across frontend/backend dialects. - No unrelated code changes were introduced. Pre-merge checks: - PR scope is minimal (2 files, focused change). - CI signal is healthy on the PR head (successful checks observed). - Unit test update reflects the intended case-insensitive behavior. Suggested merge comment: - “This change is in the right direction. It makes single-table logical name matching case-insensitive, which is necessary for cross-dialect scenarios such as Oracle uppercase physical tables accessed through lowercase MySQL-side SQL. Scope is focused, test expectation is updated accordingly, and CI is healthy. LGTM, ready to merge.” -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
