kezhenxu94 commented on pull request #5765:
URL: https://github.com/apache/shardingsphere/pull/5765#issuecomment-632986487


   > > BTW, @cherrylzhao do you think it is required to wget this third part 
file? What concerns me a bit is that we can not ensure this file exists there 
all the time, right?
   > 
   > I have no better idea currently, it need this shell to control the order 
of docker container
   
   @cherrylzhao after checking the previous pull request, if I understand 
correctly, you're trying to determine the startup order and wait for some 
services to be ready, we have the same requirement in SkyWalking too, and we 
finally did it by using docker-compose version 2 format, where you can define 
the health check and dependencies between services, take this as an example
   
   
https://github.com/apache/skywalking/blob/a12ecea4494ff9e00f81d82b4ba9119039d0e011/test/e2e/e2e-test/docker/base-compose.yml#L61-L65
   
   
https://github.com/apache/skywalking/blob/a12ecea4494ff9e00f81d82b4ba9119039d0e011/test/e2e/e2e-test/docker/simple/jdk/docker-compose.yml#L36-L38
   
   hope it helps


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to