menghaoranss commented on PR #38705: URL: https://github.com/apache/shardingsphere/pull/38705#issuecomment-4493969361
**Merge Verdict: Mergeable** Re-reviewed using ShardingSphere’s **logical schema semantics** (not physical MySQL database-name semantics), this PR is safe to merge. The change is correctly scoped: for MySQL with `lower_case_table_names=0`, it makes only `IdentifierScope.SCHEMA` case-insensitive, while keeping `TABLE`/`VIEW` case-sensitive. That matches the existing scope-aware design in `DatabaseIdentifierContextFactory` (`SCHEMA` via protocol rule, `TABLE`/`VIEW` via storage rule) and addresses the known modeling gap for this branch. Risk is low and bounded: - No hot-path complexity or I/O changes. - No broad behavior shift outside MySQL `lower_case_table_names=0` schema matching. - Counterexample behavior remains protected (`TABLE`/`VIEW` still sensitive in the same branch). Pre-merge note: when I checked, the commit status was still `pending`; merge after CI turns green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
