sandynz commented on PR #38708:
URL: https://github.com/apache/shardingsphere/pull/38708#issuecomment-4497027658
1. Decision block
- Merge Verdict: Mergeable
- Reviewed Scope: .github/workflows/nightly-e2e-operation.yml
- Not Reviewed Scope: actual scheduled workflow execution on GitHub-hosted
or self-hosted runners; full E2E runtime results.
- Need Expert Review: No dedicated domain expert review is required.
2. Basis
- The change directly addresses the workflow usability issue by adding a
workflow_dispatch input for docker-image, then generating the E2E image matrix
from either the provided single image or the default image list.
- The runtime command still maps each supported image family to the
existing E2E Maven property:
- mysql:* to e2e.docker.database.mysql.images
- mariadb:* to e2e.docker.database.mariadb.images
- postgres:* to e2e.docker.database.postgresql.images
- opengauss/* to e2e.docker.database.opengauss.images
- The default scheduled behavior is preserved because the default image
list still contains the same ShardingSphere operation E2E images as before.
- The matrix exclude rules were updated consistently after changing
matrix.image from an object to a string, so the existing unsupported
operation/image combinations remain excluded.
- Design risk is low: the added prepare-e2e-matrix job is scoped to matrix
preparation and does not alter artifact generation or E2E execution
responsibilities.
- Compatibility risk is low: this only changes GitHub Actions workflow
orchestration and does not affect runtime code, configuration schema, API/SPI,
SQL parsing, routing, or database behavior.
- Performance and operational risk are acceptable: the new preparation job
has a 5-minute timeout, and the existing E2E job still keeps max-parallel: 15.
3. Pre-merge checks
- npx --yes [email protected]
.github/workflows/nightly-e2e-operation.yml: passed.
- YAML parsing with Ruby YAML.load_file: passed.
- git diff --check -- .github/workflows/nightly-e2e-operation.yml: passed.
- Local shell validation covered:
- single-image matrix output, for example images=["mysql:8.0"]
- supported image-family property mapping for MySQL, MariaDB,
PostgreSQL, and openGauss.
- Recommended final confirmation before merge: run one workflow_dispatch
case with a single image, for example operation=[ "pipeline" ] and
docker-image=mysql:8.0, to verify the full GitHub Actions runtime path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
