linghengqian commented on issue #38686: URL: https://github.com/apache/shardingsphere/issues/38686#issuecomment-4527639997
> if Dameng officially provides an open-source and runnable Docker image for CI in the future I don't think it's necessary to open-source the Dockerfile. Personally, I believe all that's needed is a working Docker image for integration testing, and this image should come with proper documentation explaining how to use it in integration tests. The Docker image doesn't necessarily have to be hosted on Docker Hub or GHCR—any registry accessible by GitHub Actions runners is acceptable, as long as the runner can pull the image from it. This means registries restricted to internal Tencent Cloud networks, such as `ccr.ccs.tencentyun.com`, cannot be used. In fact, legal considerations are more important. The master branch of ShardingSphere currently uses the Docker image `mcr.microsoft.com/mssql/server:2025-RTM-ubuntu-22.04`, which neither has an open-source Dockerfile nor is hosted on Docker Hub or GHCR. However, `mcr.microsoft.com/mssql/server:2025-RTM-ubuntu-22.04` provides functionality to accept the EULA via a file named `container-license-acceptance.txt` placed on the classpath, as described in https://java.testcontainers.org/modules/databases/mssqlserver/ . At least Microsoft employees consider this step sufficient to ensure no legal issues arise. My opinion may not be comprehensive enough, and I still need input from another committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
