strongduanmu commented on PR #38715:
URL: https://github.com/apache/shardingsphere/pull/38715#issuecomment-4531991831
• Merge Verdict: Mergeable
- Reviewed Scope: PR latest head 35903c74b8bac31d700cf2e1ff816cbe7ecd61d8;
proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/ProxySQLComQueryParser.java:51;
proxy/backend/core/src/test/java/org/apache/
shardingsphere/proxy/backend/handler/ProxySQLComQueryParserTest.java:45;
MySQL/PostgreSQL/openGauss COM_QUERY callers.
- Not Reviewed Scope: private commercial-version delta, full manual Proxy
runtime smoke.
- Need Expert Review: No.
Basis
This PR still contains only 1 commit, 1 changed file, 3 additions, and 1
deletion, with mergeable_state=clean. The change only extracts the original
chained call:
ProxyContext.getInstance().getContextManager().getMetaDataContexts().getMetaData()
into a local ShardingSphereMetaData metaData variable before retrieving
SQLParserRule. The number of calls, retrieved object, exception propagation,
parser engine selection, empty SQL handling, and database protocol fallback all
remain
equivalent.
Risk scan result:
- Design: extracting the local variable improves readability; the boundary
remains inside ProxySQLComQueryParser, with no new abstraction or cross-layer
access.
- Performance: no new loops, I/O, remote calls, caches, or collection
allocations; no new computeIfAbsent in the changed file.
- Compatibility: no changes to SQL parser grammar, visitors, name
resolution, default schema, routing order, configuration, or API/SPI.
- Blast radius: this parser is called by MySQL/PostgreSQL/openGauss simple
query paths; extracting the variable does not change parser type selection for
any dialect.
- Adversarial pass: empty SQL still returns early; missing database still
uses the default database type; existing database still uses
getDatabase(databaseName).getProtocolType(); no feature flag or disabled path
changes.
Pre-merge Checks
- GitHub checks: completed; CI, Check - Spotless, Check - License, Check -
CheckStyle, E2E smoke/agent/pipeline/transaction checks succeeded; E2E - SQL
(Stage 2) was skipped; no pending or failed checks.
- Local verification: ProxySQLComQueryParserTest passed with 3 tests.
Commands run:
- git diff --check
cc3ab1348109451d73f978f4a4402d91205a974e..35903c74b8bac31d700cf2e1ff816cbe7ecd61d8:
exit 0
- ./mvnw -pl :shardingsphere-proxy-backend-core -am -DskipITs
-Dspotless.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -Drat.skip=true
-Dtest=org.apache.shardingsphere.proxy.backend.handler.ProxySQLComQueryParserTest
-Dsurefire.failIfNoSpecifiedTests=false test: exit 0
- GitHub PR/check-run API queries: exit 0
- git status --short --branch: exit 0, worktree clean
Self-check: latest head reviewed; no unrelated changes or unresolved risks
found. This PR is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
