terrymanu commented on PR #38719: URL: https://github.com/apache/shardingsphere/pull/38719#issuecomment-4538752815
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** Latest PR head `73d777ee48c524b3ecd6920466c8810fb987b7cd`; PR diff against `apache/master`, covering 51 files under `mcp/**` and `test/e2e/mcp/**`; latest GitHub check-runs; local verification after the final naming fix. - **Not Reviewed Scope:** Live external LLM-provider behavior beyond MCP E2E/unit coverage; non-MCP modules not touched by this PR. - **Need Expert Review:** No. ### Basis - The previous blocker in `mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/workflow/service/WorkflowRequestBinder.java` is fixed: the `Map.Entry` loop variable now uses `entry`, while the method parameter remains `userOverride`, satisfying both `CODE_OF_CONDUCT.md` naming rules. - Latest CI is green, including `MCP E2E - Default Reactor`, `MCP E2E - MySQL HTTP and STDIO`, `MCP E2E - Distribution`, Checkstyle, Spotless, License, and CI. - The earlier workflow retry wrapper was removed; no environment/dependency-transfer issue is being over-fixed as an action behavior change. - Fresh risk scan found no remaining behavior blocker. The `computeIfAbsent` occurrence in `MCPToolCallLimiter` is not newly introduced behavior and is not on the Proxy/JDBC DML/DQL high-frequency SQL path covered by the project review rule. ### Pre-Merge Checks - `./mvnw spotless:apply -Pcheck -T1C` passed locally. - `./mvnw checkstyle:check -Pcheck -T1C` passed locally. - `./mvnw -pl mcp/support -am -DskipITs -Dspotless.skip=true test -B -ntp` passed locally with `mcp-support` 350 tests, 0 failures. - `git diff --check apache/master...HEAD` passed. - Search for the previous `Map.Entry each` pattern returned no matches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
