terrymanu commented on PR #38704: URL: https://github.com/apache/shardingsphere/pull/38704#issuecomment-4538898083
P1.2: please choose (b) make it charset/collation-aware, not the ASCII-only narrowing. Once these functions are registered as MySQL LENGTH / BIT_LENGTH / LOCATE, they should preserve MySQL semantics for valid charset introducers and binary/nonbinary collation cases. If the current Calcite/UDF path cannot access that metadata yet, it is better to keep these functions unsupported for now. P1.3: please choose option 1: restrict MySQLOperatorTable to the MySQL context in this PR, and add non-MySQL counterexamples, at least PostgreSQL/openGauss, to prove that MySQL functions do not leak into other dialects. If that turns into a broader architectural change, then fall back to option 2: submit the operator-table isolation first, then continue this function support PR on top of it. For P1.1, removing Closes #31899 is enough; the CommonExpressionSegment root cause can be handled in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
