terrymanu commented on PR #38725:
URL: https://github.com/apache/shardingsphere/pull/38725#issuecomment-4545202662
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** Latest PR head
`9197a48f5b113b7a4a8fc727cc1f799d46d73dde` against `apache/master`
`96b543fd16ae5806b13b171e9353dc70ac64fd24`; reviewed the 5 changed MCP
documentation files: `docs/mcp/ShardingSphere-MCP-Detailed-Design.md`,
`docs/mcp/ShardingSphere-MCP-PRD.md`,
`docs/mcp/ShardingSphere-MCP-Technical-Design.md`, `mcp/README.md`, and
`mcp/README_ZH.md`.
- **Not Reviewed Scope:** Full repository `clean install` was not rerun
locally in this review pass; validation relies on latest-head GitHub Actions
plus scoped local MCP verification on the same head.
- **Need Expert Review:** No mandatory expert review required for this
docs-only change. Optional MCP maintainer wording sign-off is sufficient.
### Basis
- The latest revision is cleanly scoped to MCP public-contract documentation
only: 5 files changed, 78 insertions, 37 deletions.
- Previous blockers are resolved: unrelated root README changes are gone,
MCP runtime code/test refactor is gone, and trailing whitespace is gone.
- The docs now clearly mark early PRD/detailed-design sections as historical
context rather than the current public surface contract.
- The current public contract is consistently described as
descriptor-first/resource-first, with `database_gateway_*` tools as the
supported tool entry points.
- The change also clarifies that the submit-ready scope is MCP V1 runtime
readiness, not a complete ShardingSphere governance administration surface.
- Fresh risk scan found no unresolved runtime, API/SPI, SQL parser, routing,
performance, supply-chain, or cross-dialect risk because the final diff is
docs-only.
### Pre-Merge Checks
- GitHub latest-head checks are all successful:
- `Check - CheckStyle`: success
- `Check - License`: success
- `Check - Spotless`: success
- `MCP E2E - Default Reactor`: success
- `MCP E2E - Distribution`: success
- `MCP E2E - MySQL HTTP and STDIO`: success
- PR state is `clean` for head `9197a48f5b113b7a4a8fc727cc1f799d46d73dde`.
- `git diff --check apache/master...apache/pr/38725`: passed.
- Scoped local MCP verification on the same head passed:
- `./mvnw -pl mcp/bootstrap -am spotless:check -Pcheck -T1C -B -ntp`
- `./mvnw -pl mcp/bootstrap -am -DskipITs -Dspotless.skip=true test
-Dsurefire.failIfNoSpecifiedTests=false -B -ntp`
- `./mvnw -pl mcp,test/e2e/mcp -am install -DskipITs -Dspotless.skip=true
-Dsurefire.failIfNoSpecifiedTests=false -Dmcp.e2e.contract.enabled=true -B -ntp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
