terrymanu commented on PR #38736: URL: https://github.com/apache/shardingsphere/pull/38736#issuecomment-4556015158
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR #38736 latest head `c035d9b` against base `0a138a3`; `.codex/skills/review-pr/SKILL.md`; PR body, commit metadata, changed-file diff, issue comments, PR reviews, and review comments; consistency with `CODE_OF_CONDUCT.md:17`, `CODE_OF_CONDUCT.md:18`, and `CODE_OF_CONDUCT.md:19`. - **Not Reviewed Scope:** GitHub Actions/check-run status by design; production Java modules, SQL parser dialect files, Proxy/JDBC runtime behavior, and Maven build output because the PR only changes the review skill Markdown. - **Need Expert Review:** No dedicated security, concurrency, performance, protocol, or SQL parser expert review needed. ### Basis - The root issue is review-boundary clarity. The previous skill treated CI status/check results as first-priority review evidence and had a mergeable template requiring CI confirmation. The PR removes those default CI dependencies and replaces them with explicit review boundary and verification language at `.codex/skills/review-pr/SKILL.md:73`, `.codex/skills/review-pr/SKILL.md:79`, `.codex/skills/review-pr/SKILL.md:92`, `.codex/skills/review-pr/SKILL.md:97`, `.codex/skills/review-pr/SKILL.md:154`, `.codex/skills/review-pr/SKILL.md:355`, and `.codex/skills/review-pr/SKILL.md:381`. - Repository formatting/style authority is consistent with project rules because the PR names Spotless and Checkstyle as review style gates at `.codex/skills/review-pr/SKILL.md:81`, matching the project’s declared gates in `CODE_OF_CONDUCT.md:17`, `CODE_OF_CONDUCT.md:18`, and `CODE_OF_CONDUCT.md:19`. - Multi-round comparison is narrowed to GitHub-visible prior feedback at `.codex/skills/review-pr/SKILL.md:247` through `.codex/skills/review-pr/SKILL.md:250`, while latest-head review remains required at `.codex/skills/review-pr/SKILL.md:185` through `.codex/skills/review-pr/SKILL.md:187`. - Boundary-validation guidance at `.codex/skills/review-pr/SKILL.md:225` through `.codex/skills/review-pr/SKILL.md:234` is evidence-scoped and still asks for production entry-path evidence when ownership is unclear, so it does not weaken the existing insufficient-evidence rule. - No unrelated files, dependency manifests, parser grammar/visitor logic, shared execution path, name-resolution/default-schema/routing behavior, or high-frequency `ConcurrentHashMap#computeIfAbsent` path is changed. ### Verification - `curl -sL https://api.github.com/repos/apache/shardingsphere/pulls/38736` exited 0: confirmed latest head/base and one changed file; no CI/status data used. - `curl -sL https://api.github.com/repos/apache/shardingsphere/issues/38736/comments`, `curl -sL https://api.github.com/repos/apache/shardingsphere/pulls/38736/reviews`, and `curl -sL https://api.github.com/repos/apache/shardingsphere/pulls/38736/comments` exited 0: confirmed no GitHub-visible previous-round feedback to compare. - `git diff --stat 0a138a324c607a2a836005f94fbb0d66d94e159a...c035d9b44250c7b0ac3e41e1bf8567c7eeb97958` exited 0: confirmed one changed Markdown skill file. - `git diff --unified=80 0a138a324c607a2a836005f94fbb0d66d94e159a...c035d9b44250c7b0ac3e41e1bf8567c7eeb97958 -- .codex/skills/review-pr/SKILL.md` exited 0: reviewed the full patch. - `rg -n "Pre-Merge Checks|CI, tests, and compatibility confirmations|review comments, CI status, check results|When the user provides previous-round feedback or PR adds new commits" .codex/skills/review-pr/SKILL.md || true` exited 0: confirmed the old CI/check-result and old multi-round trigger wording is absent. - Maven, Spotless, and Checkstyle were not run because this is a docs-only skill Markdown change, and no local build output is being used as merge evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
