strongduanmu commented on PR #38746:
URL: https://github.com/apache/shardingsphere/pull/38746#issuecomment-4562041125
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR latest head
`4cd3ebf493985af90324ae4540710206ab0fe948`; local `HEAD` matches PR head. Local
merge-base `56526f0819e84daaab84f3584d77de3c08dfa12f`. GitHub
`/pulls/38746/files` matched local triple-dot diff.
Reviewed local latest two commits: `3206d45b2aee` and `4cd3ebf49398`.
- `test/it/parser/src/main/resources/sql/supported/dml/delete.xml:37`
- `test/it/parser/src/main/resources/case/dml/delete.xml:561`
-
`test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/storage/option/dialect/hive/HiveStorageContainerCreateOption.java:50`
- SQL parser target dialect: MySQL. Related parser family checked: Doris
copied delete grammar/visitor path; no separate MariaDB parser module exists in
this checkout.
- Official syntax references checked: [MySQL 8.4 DELETE
Statement](https://dev.mysql.com/doc/refman/8.4/en/delete.html), [MySQL 8.4
JOIN Clause](https://dev.mysql.com/doc/refman/8.4/en/join.html).
- **Not Reviewed Scope:** CI/check-run logs and local Maven/E2E reruns
were not reviewed or rerun.
- **Need Expert Review:** No.
### Basis
- The added MySQL parser case covers a valid MySQL multiple-table `DELETE`
form: delete targets are aliases before `FROM`, aliases are declared in
`table_references`, and the source tables are schema-qualified join tables.
- The parser change is fixture-only. It does not alter grammar, visitor
logic, name resolution, routing precedence, or shared runtime behavior.
- Doris has the same copied multiple-table delete grammar/visitor shape,
but this PR does not change Doris behavior and keeps the new case scoped to
`db-types="MySQL"`.
- The Hive E2E option change removes duplicated `SERVICE_OPTS`; the same
Hive settings remain in the mounted `hive-site.xml`
(`hive.support.concurrency`, `hive.txn.manager`, and
`hive.exec.dynamic.partition.mode`).
- No dependency, license, security, hot-path, or
`ConcurrentHashMap#computeIfAbsent` risk was introduced.
### Verification
- Reviewed the PR diff against GitHub file scope and local triple-dot diff.
- Checked MySQL official syntax support for the new SQL case.
- Checked adjacent parser-family impact for Doris and absence of a
separate MariaDB parser module.
- Checked the Hive container path and mounted Hive configuration path for
the removed environment option.
本轮未改文件，未跑测试。关键命令：git fetch ... exit 0，git diff --name-status
<merge-base>..refs/remotes/upstream/pr/38746 exit 0，curl .../pulls/38746/files
| jq ... exit 0，git log -2 exit 0；gh api 因本机未登录返回 exit 4，已改用
GitHub connector/curl 获取 PR facts。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
