strongduanmu commented on PR #38750:
URL: https://github.com/apache/shardingsphere/pull/38750#issuecomment-4571972640
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR #38750 latest head
`d8cac950d919a93a87da7b61961aa5d78ef66677`; local base ref `upstream/master` at
`543a55be3eb257b254fb094dcac9e1dd520515d4`; local merge-base
`8c1f9e0ffa9069cbb571e5aca5b887dac9923b26`.
Reviewed file:
`test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/cases/SQLE2ETestCasesXMLLoader.java`.
Local triple-dot file list matched GitHub `/pulls/38750/files` for the same
latest head.
- **Not Reviewed Scope:** Full SQL E2E runtime execution and GitHub
Actions/check-runs were not reviewed.
- **Need Expert Review:** No.
### Basis
- The change is scoped to the SQL E2E test case XML loader and does not
touch production code, SQL parser behavior, routing, metadata, SPI,
dependencies, or runtime configuration.
- The original classloader lookup behavior is preserved when `cases/` is
available from the context class loader (`SQLE2ETestCasesXMLLoader.java:77`).
- The added fallback only covers the resource layout where `cases` exists
beside the test code source location (`SQLE2ETestCasesXMLLoader.java:81`),
which is consistent with the module’s custom test output directory layout.
- No unrelated files or dependency/configuration changes are included.
### Verification
- Scope boundary checked with `git fetch upstream
pull/38750/head:refs/remotes/upstream/pr/38750
master:refs/remotes/upstream/master`.
- Reviewed local diff with `git diff $(git merge-base upstream/master
upstream/pr/38750)..upstream/pr/38750`.
- Latest PR ref confirmed as `d8cac950d919a93a87da7b61961aa5d78ef66677`;
changed file list contains only
`test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/cases/SQLE2ETestCasesXMLLoader.java`.
- No additional local Maven verification was run for this review-only pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
