terrymanu commented on PR #38756: URL: https://github.com/apache/shardingsphere/pull/38756#issuecomment-4576225699
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR #38756 latest head `6ed6ea8db3a650186115e4c9a34411e2ff5433bd`; local merge base `d6fdf6e11d7f080614e0bf29ab27dacf8b9750dd`; local triple-dot file list matches GitHub `/pulls/38756/files`. - **Reviewed Files:** `mcp/bootstrap/.../server-instructions.md`, `mcp/support/.../MCPModelFirstContractPayloadBuilder.java`, related unit tests, and `test/e2e/mcp/.../capabilities.yaml`. - **Not Reviewed Scope:** GitHub Actions/check-run status; unrelated MCP runtime behavior beyond the capability discovery/catalog contract. - **Need Expert Review:** No. Protocol wording was checked against the latest MCP schema, which lists `tools/list`, `resources/list`, `resources/templates/list`, `prompts/list`, and `completion/complete`. ### Basis The previous blocker is fixed. The generated payload strings in `MCPModelFirstContractPayloadBuilder` are now synchronized with the HTTP baseline contract in `capabilities.yaml`, so the live `shardingsphere://capabilities` response no longer diverges from the baseline contract. The PR remains tightly scoped to MCP guidance text and corresponding tests/baseline. It does not alter SQL parsing, routing, metadata lookup order, SPI resolution, config semantics, or high-frequency Proxy/JDBC DML/DQL execution paths. Adversarial pass: - Cross-dialect / adjacent-feature path: no database dialect, parser, router, or SQL execution behavior changes. - Config-disabled / feature-flag-off path: no production feature flag or runtime conditional is changed; the E2E contract flag only controls test execution. - Original symptom path: the live HTTP `resources/read` path for `shardingsphere://capabilities` is now covered by the baseline E2E, and direct builder/handler unit tests cover the updated strings. ### Verification - `git fetch apache master +pull/38756/head:refs/remotes/apache/pr/38756` exited `0`. - `./mvnw -pl mcp/support,mcp/core -am -DskipITs -Dspotless.skip=true -Dtest=MCPModelFirstContractPayloadBuilderTest,ServerCapabilitiesHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test` exited `0`. - `./mvnw -pl test/e2e/mcp -am -DskipITs -Dspotless.skip=true -Dtest=HttpTransportBaselineContractE2ETest -Dmcp.e2e.contract.enabled=true -Dsurefire.failIfNoSpecifiedTests=false test` exited `0`. - `./mvnw checkstyle:check -Pcheck -T1C` exited `0`. - `git status --short` is clean; `git diff --exit-code` exited `0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
